* olpc_battery_trigger_uevent() is unused
@ 2008-04-29 22:29 Adrian Bunk
2008-04-29 23:01 ` Andres Salomon
0 siblings, 1 reply; 3+ messages in thread
From: Adrian Bunk @ 2008-04-29 22:29 UTC (permalink / raw)
To: David Woodhouse, Andres Salomon; +Cc: linux-kernel
drivers/power/olpc_battery.c:olpc_battery_trigger_uevent() is unused.
Should it have been used?
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: olpc_battery_trigger_uevent() is unused
2008-04-29 22:29 olpc_battery_trigger_uevent() is unused Adrian Bunk
@ 2008-04-29 23:01 ` Andres Salomon
2008-05-01 2:16 ` Adrian Bunk
0 siblings, 1 reply; 3+ messages in thread
From: Andres Salomon @ 2008-04-29 23:01 UTC (permalink / raw)
To: Adrian Bunk; +Cc: David Woodhouse, linux-kernel
On Wed, 30 Apr 2008 01:29:51 +0300
Adrian Bunk <bunk@kernel.org> wrote:
> drivers/power/olpc_battery.c:olpc_battery_trigger_uevent() is unused.
>
> Should it have been used?
>
> cu
> Adrian
>
It will get used once the olpc power management code makes it
upstream. The olpc_register_battery_callback stuff that Andrew removed
was related to that.
Remove it now if you like, but I'm hoping to get it in for the 2.6.27
merge window.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: olpc_battery_trigger_uevent() is unused
2008-04-29 23:01 ` Andres Salomon
@ 2008-05-01 2:16 ` Adrian Bunk
0 siblings, 0 replies; 3+ messages in thread
From: Adrian Bunk @ 2008-05-01 2:16 UTC (permalink / raw)
To: Andres Salomon; +Cc: David Woodhouse, linux-kernel
On Tue, Apr 29, 2008 at 07:01:37PM -0400, Andres Salomon wrote:
> On Wed, 30 Apr 2008 01:29:51 +0300
> Adrian Bunk <bunk@kernel.org> wrote:
>
> > drivers/power/olpc_battery.c:olpc_battery_trigger_uevent() is unused.
> >
> > Should it have been used?
> >
> > cu
> > Adrian
> >
>
> It will get used once the olpc power management code makes it
> upstream. The olpc_register_battery_callback stuff that Andrew removed
> was related to that.
>
> Remove it now if you like, but I'm hoping to get it in for the 2.6.27
> merge window.
I'm not that trigger-happy. ;-)
I was actually more interested in whether it should have been used
(AKA there would be a bug somewhere).
cu
Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2008-05-01 2:18 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-29 22:29 olpc_battery_trigger_uevent() is unused Adrian Bunk
2008-04-29 23:01 ` Andres Salomon
2008-05-01 2:16 ` Adrian Bunk
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome