Re: 2.6.26, PAT and AMD family 6

[Pavel Machek <pavel@suse.cz>]

> > His commit ***added*** the three copies of the same code.
> 
> And you are not able to ******look******* over the brim of your tea
> cup and accept that one of them is 64 bit and the others are a tribute
> to the not yet distangled shit. There would have been a cleaner and
> better way to solve this, but there is always a better and cleaner way
> to do things.

Existing code being a mess is not an excuse for messing it up a bit
more. Which is exactly what Yinghai did.

> Why dont you send a cleanup patch which fixes the three copies problem
> instead of spending your time with writing up ivory tower pieces of
> wisdom ?

Because no ammount of cleanup patches will solve "Ingo did not even
notice missing changelog, and 2 NAKs"?

commit 9307cacad0dfe3749f00303125c6f7f0523e5616 
tree bc28bf08dc18dacbb2654a9a368f4e09c580dfab 
parent a7c7d0e91daebd7c5e51f9416d612b6a15e7e79a 
author Yinghai Lu <yhlu.kernel.send@gmail.com> Mon, 24 Mar 2008 23:24:34 -0700 
committer Ingo Molnar <mingo@elte.hu> Thu, 17 Apr 2008 17:41:20 +0200 

    x86: pat cpu feature bit setting for known cpus
    
    Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html