From: Arjan van de Ven <arjan@infradead.org>
To: Jesse Barnes <jbarnes@virtuousgeek.org>
Cc: linux-kernel@vger.kernel.org, akpm@linux-foundation.org,
len.brown@intel.com
Subject: Suspend/Resume bug in PCI layer wrt quirks
Date: Thu, 15 May 2008 07:05:46 -0700 [thread overview]
Message-ID: <20080515070546.6ea9c681@infradead.org> (raw)
Hi,
the following is a bug in the PCI layer wrt suspend/resume and quirks:
pci_device_resume_early does the following:
static int pci_device_resume_early(struct device * dev)
{
int error = 0;
struct pci_dev * pci_dev = to_pci_dev(dev);
struct pci_driver * drv = pci_dev->driver;
pci_fixup_device(pci_fixup_resume, pci_dev);
eg it calls the resume quirks.
However, one of these quirks is
DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_ICH6_1, asus_hides_smbus_lpc_ich6);
and asus_hides_smbus_lpc_ich6 does
base = ioremap_nocache(rcba & 0xFFFFC000, 0x4000); /* use bits 31:14, 16 kB aligned */
if (base == NULL) return;
val=readl(base + 0x3418); /* read the Function Disable register, dword mode only */
writel(val & 0xFFFFFFF7, base + 0x3418); /* enable the SMBus device */
iounmap(base);
internally. ioremap()/iounmap() does a global tlb flush of course, which includes doing an IPI to other cpus.
However, during early resume, interrupts are disabled, and it's not allowed to do a IPI/global tlbflush with interrupts
off...
This is hitting quite a few people now:
http://www.kerneloops.org/searchweek.php?search=smp_call_function
do we need a DECLARE_PCI_FIXUP_RESUME_LATE() and use that for this one?
next reply other threads:[~2008-05-15 14:06 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-15 14:05 Arjan van de Ven [this message]
2008-05-15 16:07 ` Jesse Barnes
2008-05-15 17:54 ` Arjan van de Ven
2008-05-15 19:51 ` Rafael J. Wysocki
2008-05-16 17:51 ` Jesse Barnes
2008-05-16 20:16 ` Rafael J. Wysocki
2008-05-16 21:37 ` Greg KH
2008-05-19 19:09 ` Jesse Barnes
2008-05-19 22:49 ` Rafael J. Wysocki
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080515070546.6ea9c681@infradead.org \
--to=arjan@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=jbarnes@virtuousgeek.org \
--cc=len.brown@intel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®