Re: Suspend/Resume bug in PCI layer wrt quirks

[Jesse Barnes <jbarnes@virtuousgeek.org>]

On Friday, May 16, 2008 2:37 pm Greg KH wrote:
> On Fri, May 16, 2008 at 10:16:30PM +0200, Rafael J. Wysocki wrote:
> > On Friday, 16 of May 2008, Jesse Barnes wrote:
> > > On Thursday, May 15, 2008 12:51 pm Rafael J. Wysocki wrote:
> > > > Some quirks should be called with interrupt disabled, we can't
> > > > directly call them in .resume_early. Also the patch introduces
> > > > pci_fixup_resume_early and pci_fixup_suspend, which matches current
> > > > device core callbacks (.suspend/.resume_early).
> > > >
> > > > TBD: Somebody knows why we need quirk resume should double check if a
> > > > quirk should be called in resume or resume_early. I changed some per
> > > > my understanding, but can't make sure I fixed all.
> > > >
> > > > Signed-off-by: Shaohua Li <shaohua.li@intel.com>
> > >
> > > I applied this one to linux-next, it should fix some of the problems
> > > people have been seeing at least...
> >
> > Well, that will collide with
> > pm-new-suspend-and-hibernation-callbacks-for-pci-bus-type.patch
> > in the Greg's tree.
> >
> > Greg, perhaps it's better if you drop it and I'll send an updated version
> > to Jesse?  That will make his tree dependent on yours, but that will be
> > okay, won't it?
>
> That's up to Jesse.  I don't know if he can handle a depancy on an
> external tree.
>
> Jesse?

It would be easiest for me to just carry Rafael's patch, but that assumes 
you're ok with the changes.  Have you looked at it enough to feel good about 
it, Greg?

Thanks,
Jesse