From: Willy Tarreau <w@1wt.eu>
To: Jeremy Fitzhardinge <jeremy@goop.org>
Cc: Sam Ravnborg <sam@ravnborg.org>, "H. Peter Anvin" <hpa@zytor.com>,
Steve French <smfrench@gmail.com>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: kernel coding style for if ... else which cross #ifdef
Date: Sat, 24 May 2008 16:46:27 +0200 [thread overview]
Message-ID: <20080524144627.GB4166@1wt.eu> (raw)
In-Reply-To: <48382911.8090807@goop.org>
On Sat, May 24, 2008 at 03:41:21PM +0100, Jeremy Fitzhardinge wrote:
> Willy Tarreau wrote:
> >You still have the possibility to use the "-0" trick :
> >
> > if (CFG_THINGY_LIMIT && x > (CONFIG_THINGY_LIMIT-0)) {...}
> >
>
> Oh, that's cute in a vile way. I hadn't seen it before.
I use it in some of my code (but moderately). It's particularly useful
for limit checking such as above. It's useful too when you want to use
the config value as an offset or a bit shift. Eg:
p = malloc(buf_size << (CONFIG_SHIFT-0));
Willy
next prev parent reply other threads:[~2008-05-24 14:46 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-05-23 19:11 Steve French
2008-05-23 20:42 ` Willy Tarreau
2008-05-23 20:49 ` Adrian Bunk
2008-05-23 21:05 ` Willy Tarreau
2008-05-23 23:03 ` H. Peter Anvin
2008-05-24 5:43 ` Sam Ravnborg
2008-05-24 5:42 ` H. Peter Anvin
2008-05-24 6:42 ` Sam Ravnborg
2008-05-24 10:06 ` Jeremy Fitzhardinge
2008-05-24 10:49 ` Adrian Bunk
2008-05-24 11:27 ` Sam Ravnborg
2008-05-24 14:35 ` Jeremy Fitzhardinge
2008-05-24 14:39 ` Willy Tarreau
2008-05-24 14:41 ` Jeremy Fitzhardinge
2008-05-24 14:46 ` Willy Tarreau [this message]
2008-05-24 15:36 ` Sam Ravnborg
2008-05-24 15:45 ` Jeremy Fitzhardinge
2008-05-24 15:57 ` Vegard Nossum
2008-05-24 16:02 ` Jeremy Fitzhardinge
2008-05-24 16:40 ` Tom Spink
2008-05-24 16:42 ` Tom Spink
2008-05-24 20:38 ` Jeremy Fitzhardinge
2008-05-24 20:43 ` H. Peter Anvin
2008-05-24 20:51 ` Jeremy Fitzhardinge
2008-05-24 20:54 ` H. Peter Anvin
2008-05-24 21:15 ` Jeremy Fitzhardinge
2008-05-25 23:57 ` Adrian Bunk
2008-05-26 0:27 ` H. Peter Anvin
2008-05-24 18:12 ` H. Peter Anvin
2008-05-24 18:12 ` H. Peter Anvin
2008-05-24 18:51 ` Sam Ravnborg
2008-05-24 18:08 ` H. Peter Anvin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080524144627.GB4166@1wt.eu \
--to=w@1wt.eu \
--cc=hpa@zytor.com \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=smfrench@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®