Re: [PATCH] quota: Split out quota_struct.h out of quota.h

[Adrian Bunk <bunk@kernel.org>]

On Mon, Jun 02, 2008 at 07:11:10PM +0200, Jan Kara wrote:
> Split some structure definitions from quota.h to quota_struct.h so that they
> can be separately included in fs.h. This makes it possible to declare some
> useful inline functions in quota.h because it can now include fs.h.
> 
> Signed-off-by: Jan Kara <jack@suse.cz>
> ---
>  include/linux/fs.h       |    2 +-
>  include/linux/quota.h    |  193 +---------------------------------------------
>  include/linux/quotaops.h |    1 +
>  include/linux/syscalls.h |    2 +-
>  4 files changed, 5 insertions(+), 193 deletions(-)
>...

Missing "git-add include/linux/quota_struct.h" ?

> --- a/include/linux/quota.h
> +++ b/include/linux/quota.h
> @@ -37,13 +37,11 @@
>  
>  #include <linux/errno.h>
>  #include <linux/types.h>
> +#include <linux/quota_struct.h>
>...

This breaks our userspace headers.

Please always run "make headers_check" after touching #include's
under include/

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed