Re: [PATCH] quota: Split out quota_struct.h out of quota.h

[Adrian Bunk <bunk@kernel.org>]

On Wed, Jun 04, 2008 at 04:51:30PM +0200, Jan Kara wrote:
> On Wed 04-06-08 16:56:24, Adrian Bunk wrote:
> > On Mon, Jun 02, 2008 at 07:11:10PM +0200, Jan Kara wrote:
>...
> > > --- a/include/linux/quota.h
> > > +++ b/include/linux/quota.h
> > > @@ -37,13 +37,11 @@
> > >  
> > >  #include <linux/errno.h>
> > >  #include <linux/types.h>
> > > +#include <linux/quota_struct.h>
> > >...
> > 
> > This breaks our userspace headers.
> > 
> > Please always run "make headers_check" after touching #include's
> > under include/
>   I didn't know this existed :) I'll use it in future. Thanks. The question
> is how to fix this. Probably the best would be if didn't have to export new
> header file, wouldn't it? We can split the headers into quota.h containing
> structures and all other userspace stuff and quota_func.h carrying other
> kernel-internal stuff like inline functions etc. Oh well...

Considering that quota.h #include's quota_struct.h it wouldn't be a 
problem if the new header also gets exported to userspace.

At least I do not have any strong opinion regarding how to best organize 
the quota headers - David (Cc'ed) might have a more input on this.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed