Re: [PATCH] quota: Split out quota_struct.h out of quota.h

[Jan Kara <jack@suse.cz>]

On Wed 04-06-08 16:56:24, Adrian Bunk wrote:
> On Mon, Jun 02, 2008 at 07:11:10PM +0200, Jan Kara wrote:
> > Split some structure definitions from quota.h to quota_struct.h so that they
> > can be separately included in fs.h. This makes it possible to declare some
> > useful inline functions in quota.h because it can now include fs.h.
> > 
> > Signed-off-by: Jan Kara <jack@suse.cz>
> > ---
> >  include/linux/fs.h       |    2 +-
> >  include/linux/quota.h    |  193 +---------------------------------------------
> >  include/linux/quotaops.h |    1 +
> >  include/linux/syscalls.h |    2 +-
> >  4 files changed, 5 insertions(+), 193 deletions(-)
> >...
> 
> Missing "git-add include/linux/quota_struct.h" ?
  Probably yes, I already noticed this and mailed Andrew a patch with this
file included.

> > --- a/include/linux/quota.h
> > +++ b/include/linux/quota.h
> > @@ -37,13 +37,11 @@
> >  
> >  #include <linux/errno.h>
> >  #include <linux/types.h>
> > +#include <linux/quota_struct.h>
> >...
> 
> This breaks our userspace headers.
> 
> Please always run "make headers_check" after touching #include's
> under include/
  I didn't know this existed :) I'll use it in future. Thanks. The question
is how to fix this. Probably the best would be if didn't have to export new
header file, wouldn't it? We can split the headers into quota.h containing
structures and all other userspace stuff and quota_func.h carrying other
kernel-internal stuff like inline functions etc. Oh well...

									Honza
-- 
Jan Kara <jack@suse.cz>
SUSE Labs, CR