* [2.6 patch] jfs: remove DIRENTSIZ
@ 2008-06-09 22:27 Adrian Bunk
2008-06-10 20:19 ` Dave Kleikamp
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2008-06-09 22:27 UTC (permalink / raw)
To: shaggy; +Cc: jfs-discussion, linux-kernel
After fat gets fixed the unused DIRENTSIZ macro was the last user of
struct dirent we should get rid of since the kernel and userspace
versions differed.
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
89432c9b7ff2cd2e29fc5f2edde120dc38a89f46 diff --git a/fs/jfs/jfs_dtree.h b/fs/jfs/jfs_dtree.h
index cdac2d5..2545bb3 100644
--- a/fs/jfs/jfs_dtree.h
+++ b/fs/jfs/jfs_dtree.h
@@ -243,9 +243,6 @@ typedef union {
#define JFS_REMOVE 3
#define JFS_RENAME 4
-#define DIRENTSIZ(namlen) \
- ( (sizeof(struct dirent) - 2*(JFS_NAME_MAX+1) + 2*((namlen)+1) + 3) &~ 3 )
-
/*
* Maximum file offset for directories.
*/
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [2.6 patch] jfs: remove DIRENTSIZ
2008-06-09 22:27 [2.6 patch] jfs: remove DIRENTSIZ Adrian Bunk
@ 2008-06-10 20:19 ` Dave Kleikamp
0 siblings, 0 replies; 2+ messages in thread
From: Dave Kleikamp @ 2008-06-10 20:19 UTC (permalink / raw)
To: Adrian Bunk; +Cc: jfs-discussion, linux-kernel
Ack.
Added to the jfs git tree. As this is an unused macro, removing the
definition of struct dirent shouldn't depend on this patch. Expect it
to make the 2.6.27 merge window.
Thanks,
Shaggy
On Tue, 2008-06-10 at 01:27 +0300, Adrian Bunk wrote:
> After fat gets fixed the unused DIRENTSIZ macro was the last user of
> struct dirent we should get rid of since the kernel and userspace
> versions differed.
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
>
> ---
> 89432c9b7ff2cd2e29fc5f2edde120dc38a89f46 diff --git a/fs/jfs/jfs_dtree.h b/fs/jfs/jfs_dtree.h
> index cdac2d5..2545bb3 100644
> --- a/fs/jfs/jfs_dtree.h
> +++ b/fs/jfs/jfs_dtree.h
> @@ -243,9 +243,6 @@ typedef union {
> #define JFS_REMOVE 3
> #define JFS_RENAME 4
>
> -#define DIRENTSIZ(namlen) \
> - ( (sizeof(struct dirent) - 2*(JFS_NAME_MAX+1) + 2*((namlen)+1) + 3) &~ 3 )
> -
> /*
> * Maximum file offset for directories.
> */
>
--
David Kleikamp
IBM Linux Technology Center
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-06-10 20:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-06-09 22:27 [2.6 patch] jfs: remove DIRENTSIZ Adrian Bunk
2008-06-10 20:19 ` Dave Kleikamp
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®