From: Paul Jackson <pj@sgi.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Yinghai Lu" <yhlu.kernel@gmail.com>,
"Jack Steiner" <steiner@sgi.com>, "Mike Travis" <travis@sgi.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, "Huang,
Ying" <ying.huang@intel.com>, "Andi Kleen" <andi@firstfloor.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
Paul Jackson <pj@sgi.com>
Subject: [PATCH 3/8] x86 boot: x86_64 efi compiler warning fix
Date: Sun, 15 Jun 2008 23:29:56 -0700 [thread overview]
Message-ID: <20080616062956.14597.10460.sendpatchset@polaris-admin.engr.sgi.com> (raw)
In-Reply-To: <20080616062945.14597.78009.sendpatchset@polaris-admin.engr.sgi.com>
From: Paul Jackson <pj@sgi.com>
Fix a compiler warning. Rather than always casting a u32 to a pointer
(which generates a warning on x86_64 systems) instead separate the
x86_32 and x86_64 assignments entirely with ifdefs. Until other recent
changes to this code, it used to have x86_64 separated like this.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
arch/x86/kernel/efi.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
--- linux.orig/arch/x86/kernel/efi.c 2008-06-12 17:18:57.000000000 -0700
+++ linux/arch/x86/kernel/efi.c 2008-06-12 17:32:14.984928792 -0700
@@ -242,9 +242,11 @@ void __init efi_reserve_early(void)
{
unsigned long pmap;
+#ifdef CONFIG_X86_32
pmap = boot_params.efi_info.efi_memmap;
-#ifdef CONFIG_X86_64
- pmap += (__u64)boot_params.efi_info.efi_memmap_hi << 32;
+#else
+ pmap = (boot_params.efi_info.efi_memmap |
+ ((__u64)boot_params.efi_info.efi_memmap_hi<<32));
#endif
memmap.phys_map = (void *)pmap;
memmap.nr_map = boot_params.efi_info.efi_memmap_size /
@@ -284,10 +286,12 @@ void __init efi_init(void)
int i = 0;
void *tmp;
+#ifdef CONFIG_X86_32
efi_phys.systab = (efi_system_table_t *)boot_params.efi_info.efi_systab;
-#ifdef CONFIG_X86_64
- efi_phys.systab = (void *)efi_phys.systab +
- ((__u64)boot_params.efi_info.efi_systab_hi<<32);
+#else
+ efi_phys.systab = (efi_system_table_t *)
+ (boot_params.efi_info.efi_systab |
+ ((__u64)boot_params.efi_info.efi_systab_hi<<32));
#endif
efi.systab = early_ioremap((unsigned long)efi_phys.systab,
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2008-06-16 6:30 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 6:29 [PATCH 1/8] x86 boot: x86_64 build reserve_bootmem_generic fix Paul Jackson
2008-06-16 6:29 ` [PATCH 2/8] x86 boot: e820 code indentation fix Paul Jackson
2008-06-16 6:29 ` Paul Jackson [this message]
2008-06-16 6:30 ` [PATCH 4/8] x86 boot: allow overlapping ebda and efi memmap memory ranges Paul Jackson
2008-06-16 6:54 ` Yinghai Lu
2008-06-16 7:32 ` Paul Jackson
2008-06-16 7:34 ` Yinghai Lu
2008-06-16 8:31 ` Paul Jackson
2008-06-16 7:07 ` Huang, Ying
2008-06-16 8:24 ` Paul Jackson
2008-06-16 8:53 ` Huang, Ying
2008-06-16 9:09 ` Paul Jackson
2008-06-16 9:14 ` Huang, Ying
2008-06-16 15:48 ` H. Peter Anvin
2008-06-16 16:38 ` Paul Jackson
2008-06-16 17:05 ` H. Peter Anvin
2008-06-16 17:37 ` Paul Jackson
2008-06-16 17:41 ` Yinghai Lu
2008-06-16 18:09 ` Paul Jackson
2008-06-16 18:18 ` H. Peter Anvin
2008-06-16 18:53 ` Alan Cox
2008-06-16 19:58 ` H. Peter Anvin
2008-06-16 17:46 ` H. Peter Anvin
2008-06-16 18:05 ` Paul Jackson
2008-06-17 1:00 ` Huang, Ying
2008-06-16 6:30 ` [PATCH 5/8] x86 boot: remap efi systab runtime from phys to virt Paul Jackson
2008-06-16 7:02 ` Huang, Ying
2008-06-16 8:06 ` Paul Jackson
2008-06-16 8:27 ` Huang, Ying
2008-06-16 8:26 ` Paul Jackson
2008-06-16 6:30 ` [PATCH 6/8] x86 boot: virtualize the efi runtime function callback addresses Paul Jackson
2008-06-16 6:30 ` [PATCH 7/8] x86 boot: show pfn addresses in hex not decimal in some kernel info printks Paul Jackson
2008-06-16 7:05 ` Yinghai Lu
2008-06-16 8:09 ` Paul Jackson
2008-06-16 6:30 ` [PATCH 8/8] x86 boot: more consistently use type int for node ids Paul Jackson
2008-06-16 6:50 ` [PATCH 1/8] x86 boot: x86_64 build reserve_bootmem_generic fix Yinghai Lu
2008-06-16 8:40 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616062956.14597.10460.sendpatchset@polaris-admin.engr.sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome