From: Paul Jackson <pj@sgi.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
"Yinghai Lu" <yhlu.kernel@gmail.com>,
"Jack Steiner" <steiner@sgi.com>, "Mike Travis" <travis@sgi.com>,
"H. Peter Anvin" <hpa@zytor.com>,
linux-kernel@vger.kernel.org, "Huang,
Ying" <ying.huang@intel.com>, "Andi Kleen" <andi@firstfloor.org>,
"Andrew Morton" <akpm@linux-foundation.org>,
Paul Jackson <pj@sgi.com>
Subject: [PATCH 7/8] x86 boot: show pfn addresses in hex not decimal in some kernel info printks
Date: Sun, 15 Jun 2008 23:30:16 -0700 [thread overview]
Message-ID: <20080616063016.14597.78459.sendpatchset@polaris-admin.engr.sgi.com> (raw)
In-Reply-To: <20080616062945.14597.78009.sendpatchset@polaris-admin.engr.sgi.com>
From: Paul Jackson <pj@sgi.com>
Page frame numbers (the portion of physical addresses above the low
order page offsets) are displayed in several kernel debug and info
prints in decimal, not hex. Decimal addresse are unreadable. Use hex.
Signed-off-by: Paul Jackson <pj@sgi.com>
---
arch/x86/kernel/e820.c | 2 +-
mm/page_alloc.c | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
--- linux.orig/arch/x86/kernel/e820.c 2008-06-15 21:51:59.643086905 -0700
+++ linux/arch/x86/kernel/e820.c 2008-06-15 21:51:59.787095630 -0700
@@ -816,7 +816,7 @@ unsigned long __init e820_end_of_ram(voi
if (last_pfn > end_user_pfn)
last_pfn = end_user_pfn;
- printk(KERN_INFO "last_pfn = %lu max_arch_pfn = %lu\n",
+ printk(KERN_INFO "last_pfn = 0x%lx max_arch_pfn = 0x%lx\n",
last_pfn, max_arch_pfn);
return last_pfn;
}
--- linux.orig/mm/page_alloc.c 2008-06-15 21:51:56.890920168 -0700
+++ linux/mm/page_alloc.c 2008-06-15 21:57:04.525557420 -0700
@@ -529,7 +529,7 @@ static void __free_pages_ok(struct page
int i;
int reserved = 0;
- trace_mark(mm_page_free, "order %u pfn %lu",
+ trace_mark(mm_page_free, "order %u pfn 0x%lx",
order, page_to_pfn(page));
for (i = 0 ; i < (1 << order) ; ++i)
@@ -998,7 +998,7 @@ static void free_hot_cold_page(struct pa
struct per_cpu_pages *pcp;
unsigned long flags;
- trace_mark(mm_page_free, "order %u pfn %lu", 0, page_to_pfn(page));
+ trace_mark(mm_page_free, "order %u pfn 0x%lx", 0, page_to_pfn(page));
if (PageAnon(page))
page->mapping = NULL;
@@ -1665,7 +1665,7 @@ nopage:
}
got_pg:
if (page)
- trace_mark(mm_page_alloc, "order %u pfn %lu", order,
+ trace_mark(mm_page_alloc, "order %u pfn 0x%lx", order,
page_to_pfn(page));
return page;
}
@@ -3546,7 +3546,7 @@ void __init add_active_range(unsigned in
{
int i;
- printk(KERN_DEBUG "Entering add_active_range(%d, %lu, %lu) "
+ printk(KERN_DEBUG "Entering add_active_range(%d, 0x%lx, 0x%lx) "
"%d entries of %d used\n",
nid, start_pfn, end_pfn,
nr_nodemap_entries, MAX_ACTIVE_REGIONS);
@@ -3945,7 +3945,7 @@ void __init free_area_init_nodes(unsigne
for (i = 0; i < MAX_NR_ZONES; i++) {
if (i == ZONE_MOVABLE)
continue;
- printk(" %-8s %8lu -> %8lu\n",
+ printk(" %-8s 0x%8lx -> 0x%8lx\n",
zone_names[i],
arch_zone_lowest_possible_pfn[i],
arch_zone_highest_possible_pfn[i]);
@@ -3961,7 +3961,7 @@ void __init free_area_init_nodes(unsigne
/* Print out the early_node_map[] */
printk("early_node_map[%d] active PFN ranges\n", nr_nodemap_entries);
for (i = 0; i < nr_nodemap_entries; i++)
- printk(" %3d: %8lu -> %8lu\n", early_node_map[i].nid,
+ printk(" %3d: 0x%8lx -> 0x%8lx\n", early_node_map[i].nid,
early_node_map[i].start_pfn,
early_node_map[i].end_pfn);
--
I won't rest till it's the best ...
Programmer, Linux Scalability
Paul Jackson <pj@sgi.com> 1.650.933.1373
next prev parent reply other threads:[~2008-06-16 6:32 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-16 6:29 [PATCH 1/8] x86 boot: x86_64 build reserve_bootmem_generic fix Paul Jackson
2008-06-16 6:29 ` [PATCH 2/8] x86 boot: e820 code indentation fix Paul Jackson
2008-06-16 6:29 ` [PATCH 3/8] x86 boot: x86_64 efi compiler warning fix Paul Jackson
2008-06-16 6:30 ` [PATCH 4/8] x86 boot: allow overlapping ebda and efi memmap memory ranges Paul Jackson
2008-06-16 6:54 ` Yinghai Lu
2008-06-16 7:32 ` Paul Jackson
2008-06-16 7:34 ` Yinghai Lu
2008-06-16 8:31 ` Paul Jackson
2008-06-16 7:07 ` Huang, Ying
2008-06-16 8:24 ` Paul Jackson
2008-06-16 8:53 ` Huang, Ying
2008-06-16 9:09 ` Paul Jackson
2008-06-16 9:14 ` Huang, Ying
2008-06-16 15:48 ` H. Peter Anvin
2008-06-16 16:38 ` Paul Jackson
2008-06-16 17:05 ` H. Peter Anvin
2008-06-16 17:37 ` Paul Jackson
2008-06-16 17:41 ` Yinghai Lu
2008-06-16 18:09 ` Paul Jackson
2008-06-16 18:18 ` H. Peter Anvin
2008-06-16 18:53 ` Alan Cox
2008-06-16 19:58 ` H. Peter Anvin
2008-06-16 17:46 ` H. Peter Anvin
2008-06-16 18:05 ` Paul Jackson
2008-06-17 1:00 ` Huang, Ying
2008-06-16 6:30 ` [PATCH 5/8] x86 boot: remap efi systab runtime from phys to virt Paul Jackson
2008-06-16 7:02 ` Huang, Ying
2008-06-16 8:06 ` Paul Jackson
2008-06-16 8:27 ` Huang, Ying
2008-06-16 8:26 ` Paul Jackson
2008-06-16 6:30 ` [PATCH 6/8] x86 boot: virtualize the efi runtime function callback addresses Paul Jackson
2008-06-16 6:30 ` Paul Jackson [this message]
2008-06-16 7:05 ` [PATCH 7/8] x86 boot: show pfn addresses in hex not decimal in some kernel info printks Yinghai Lu
2008-06-16 8:09 ` Paul Jackson
2008-06-16 6:30 ` [PATCH 8/8] x86 boot: more consistently use type int for node ids Paul Jackson
2008-06-16 6:50 ` [PATCH 1/8] x86 boot: x86_64 build reserve_bootmem_generic fix Yinghai Lu
2008-06-16 8:40 ` Paul Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080616063016.14597.78459.sendpatchset@polaris-admin.engr.sgi.com \
--to=pj@sgi.com \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=steiner@sgi.com \
--cc=tglx@linutronix.de \
--cc=travis@sgi.com \
--cc=yhlu.kernel@gmail.com \
--cc=ying.huang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome