[PATCH] softlockup: print a module list on being stuck

[PATCH] softlockup: print a module list on being stuck

[Arjan van de Ven]

From: Arjan van de Ven <arjan@linux.intel.com>
Subject: [PATCH] softlockup: print a module list on being stuck

Most places in the kernel that go BUG: print a module list
(which is very useful for doing statistics and finding patterns),
however the softlockup detector does not do this yet.

This patch adds the one line change to fix this gap.

Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
---
 kernel/softlockup.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/softlockup.c b/kernel/softlockup.c
index 01b6522..47cc709 100644
--- a/kernel/softlockup.c
+++ b/kernel/softlockup.c
@@ -115,6 +115,7 @@ void softlockup_tick(void)
 	printk(KERN_ERR "BUG: soft lockup - CPU#%d stuck for %lus! [%s:%d]\n",
 			this_cpu, now - touch_timestamp,
 			current->comm, task_pid_nr(current));
+	print_modules();
 	if (regs)
 		show_regs(regs);
 	else
-- 
1.5.4.5


-- 
If you want to reach me at my work email, use arjan@linux.intel.com
For development, discussion and tips for power savings, 
visit http://www.lesswatts.org

Re: [PATCH] softlockup: print a module list on being stuck

[Ingo Molnar]

* Arjan van de Ven <arjan@infradead.org> wrote:

> From: Arjan van de Ven <arjan@linux.intel.com>
> Subject: [PATCH] softlockup: print a module list on being stuck
> 
> Most places in the kernel that go BUG: print a module list (which is 
> very useful for doing statistics and finding patterns), however the 
> softlockup detector does not do this yet.
> 
> This patch adds the one line change to fix this gap.

applied to tip/core/softlockup - thanks Arjan.

	Ingo

[patch] softlockup: print a module list on being stuck

[Ingo Molnar]

Linus,

Arjan has been observing lots of softlockup reports on kerneloops.org 
and would like to have the patch below in v2.6.26 to narrow the real 
source of it down some more, and has asked for this patch to be applied 
sooner than planned.

The patch is queued up for the next merge window at the moment. It's 
well-tested and obvious. The module list is printed here the same way 
it's printed for oopses.

Discard it if you feel in any way nervous about it.

	Ingo

---------------->
commit 688c91755dc3d3c03d8c67c1df13c02be258768e
Author: Arjan van de Ven <arjan@linux.intel.com>
Date:       Mon Jun 16 15:51:08 2008 -0700
CommitDate: Wed Jun 18 15:26:54 2008 +0200

    softlockup: print a module list on being stuck
    
    Most places in the kernel that go BUG: print a module list
    (which is very useful for doing statistics and finding patterns),
    however the softlockup detector does not do this yet.
    
    This patch adds the one line change to fix this gap.
    
    Signed-off-by: Arjan van de Ven <arjan@linux.intel.com>
    Signed-off-by: Ingo Molnar <mingo@elte.hu>

diff --git a/kernel/softlockup.c b/kernel/softlockup.c
index 6b682d8..f2bf5de 100644
--- a/kernel/softlockup.c
+++ b/kernel/softlockup.c
@@ -143,6 +143,7 @@ void softlockup_tick(void)
 	printk(KERN_ERR "BUG: soft lockup - CPU#%d stuck for %lus! [%s:%d]\n",
 			this_cpu, now - touch_timestamp,
 			current->comm, task_pid_nr(current));
+	print_modules();
 	if (regs)
 		show_regs(regs);
 	else