Re: [PATCH 3/3] mmc: Add per-card debugfs support

[Pierre Ossman <drzeus-mmc@drzeus.cx>]

On Thu, 26 Jun 2008 13:09:49 +0200
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:

> For each card successfully added to the bus, create a subdirectory under
> the host's debugfs root with information about the card.
> 
> At the moment, only a single file is added to the card directory:
> "status". Reading this file will ask the card about its current status
> and return it. This can be useful if the card just refuses to respond to
> any commands, which might indicate that the card state is not what the
> MMC core thinks it is (due to a missing stop command, for example.)
> 
> Signed-off-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
> ---

The status command doesn't work on SDIO cards, so this seems like the
wrong place for it.

> +#else
> +static inline void mmc_add_card_debugfs(struct mmc_card *card)
> +{
> +
> +}
> +
> +static inline void mmc_remove_card_debugfs(struct mmc_card *card)
> +{
> +
> +}
> +#endif
> +

ifdef the calls here as well.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.