Re: [PATCH 1/3] mmc: Export internal host state through debugfs

[Pierre Ossman <drzeus-mmc@drzeus.cx>]

On Sat, 28 Jun 2008 16:41:46 +0200
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:

> Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> > Actually, if debugfs is disabled, debugfs_create_dir() and friends are
> > inline functions which return ERR_PTR(-ENODEV). So if we just remove
> > the whole #ifdef altogether, gcc should be smart enough to optimize
> > away the whole thing if debugfs isn't enabled...
> > 
> > I'll give it a try.
> 
> Yeah, it does seem to work, but it means we'll have to put at least
> debugfs_root into struct mmc_host unconditionally. Assuming we find a
> way to not put all the other stuff in there, is that acceptable?
> 

Sounds good.

-- 
     -- Pierre Ossman

  Linux kernel, MMC maintainer        http://www.kernel.org
  rdesktop, core developer          http://www.rdesktop.org

  WARNING: This correspondence is being monitored by the
  Swedish government. Make sure your server uses encryption
  for SMTP traffic and consider using PGP for end-to-end
  encryption.