From: Pierre Ossman <drzeus-mmc@drzeus.cx>
To: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH 3/3] mmc: Add per-card debugfs support
Date: Sat, 28 Jun 2008 18:11:45 +0200 [thread overview]
Message-ID: <20080628181145.60c55ea0@mjolnir.drzeus.cx> (raw)
In-Reply-To: <20080628173637.53e3279f@hskinnemo-gx745.norway.atmel.com>
On Sat, 28 Jun 2008 17:36:37 +0200
Haavard Skinnemoen <haavard.skinnemoen@atmel.com> wrote:
> Pierre Ossman <drzeus-mmc@drzeus.cx> wrote:
> >
> > An alternative to sticking it into mmc.c is to create a debugfs.c that
> > contains all the uglyness. Debugging code isn't quite as important to
> > keep crystal clear.
>
> But if we're going to rely on gcc optimizing the whole thing away when
> debugfs is disabled, we must keep these buggers in the same file as its
> caller...
>
> Though I suppose an extra function call that does nothing at host and
> card registration time isn't a very high price to pay for cleaner code.
>
This is in the device addition/removal code as well. Hardly a hotpath.
--
-- Pierre Ossman
Linux kernel, MMC maintainer http://www.kernel.org
rdesktop, core developer http://www.rdesktop.org
WARNING: This correspondence is being monitored by the
Swedish government. Make sure your server uses encryption
for SMTP traffic and consider using PGP for end-to-end
encryption.
next prev parent reply other threads:[~2008-06-28 16:11 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-06-26 11:09 [PATCH 1/3] mmc: Export internal host state through debugfs Haavard Skinnemoen
2008-06-26 11:09 ` [PATCH 2/3] mmc: Export ios settings for a host " Haavard Skinnemoen
2008-06-26 11:09 ` [PATCH 3/3] mmc: Add per-card debugfs support Haavard Skinnemoen
2008-06-28 13:37 ` Pierre Ossman
2008-06-28 13:48 ` Haavard Skinnemoen
2008-06-28 14:01 ` Pierre Ossman
2008-06-28 14:15 ` Haavard Skinnemoen
2008-06-28 15:22 ` Pierre Ossman
2008-06-28 15:36 ` Haavard Skinnemoen
2008-06-28 16:11 ` Pierre Ossman [this message]
2008-06-28 13:34 ` [PATCH 2/3] mmc: Export ios settings for a host through debugfs Pierre Ossman
2008-06-28 13:47 ` Haavard Skinnemoen
2008-06-28 13:59 ` Pierre Ossman
2008-06-28 14:07 ` Haavard Skinnemoen
2008-06-28 15:33 ` Greg KH
2008-06-28 16:08 ` Haavard Skinnemoen
2008-06-28 16:37 ` Haavard Skinnemoen
2008-06-28 16:43 ` Greg KH
2008-06-28 17:02 ` Haavard Skinnemoen
2008-06-28 13:28 ` [PATCH 1/3] mmc: Export internal host state " Pierre Ossman
2008-06-28 13:37 ` Haavard Skinnemoen
2008-06-28 13:40 ` Pierre Ossman
2008-06-28 13:49 ` Haavard Skinnemoen
2008-06-28 14:23 ` Haavard Skinnemoen
2008-06-28 14:41 ` Haavard Skinnemoen
2008-06-28 15:17 ` Pierre Ossman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080628181145.60c55ea0@mjolnir.drzeus.cx \
--to=drzeus-mmc@drzeus.cx \
--cc=haavard.skinnemoen@atmel.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome