mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Cc: tk@maintech.de, laforge@openmoko.org, Ben Dooks <ben-linux@fluff.org>
Subject: [patch v4 06/17] MMC: Fix S3C24XX IRQ enable during PIO transfers
Date: Mon, 30 Jun 2008 16:25:53 +0100	[thread overview]
Message-ID: <20080630152747.966770291@fluff.org.uk> (raw)
In-Reply-To: <20080630152547.755285683@fluff.org.uk>

[-- Attachment #1: thirdparty/openmoko-mci/s3cmci-unfinished-write-fix.patch --]
[-- Type: text/plain, Size: 1184 bytes --]

From: Roman Moracik <roman.moravcik@gmail.com> 

Fix Bug #677 - I/O errors on heavy microSD writes for 2.6.22.x.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

Index: linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c
===================================================================
--- linux-2.6.26-rc8-next20080627.orig/drivers/mmc/host/s3cmci.c	2008-06-30 12:19:15.000000000 +0100
+++ linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c	2008-06-30 12:19:16.000000000 +0100
@@ -335,6 +335,8 @@ static void pio_tasklet(unsigned long da
 	struct s3cmci_host *host = (struct s3cmci_host *) data;
 
 
+	disable_irq(host->irq);
+
 	if (host->pio_active == XFER_WRITE)
 		do_pio_write(host);
 
@@ -352,9 +354,9 @@ static void pio_tasklet(unsigned long da
 			host->mrq->data->error = -EINVAL;
 		}
 
-		disable_irq(host->irq);
 		finalize_request(host);
-	}
+	} else
+		enable_irq(host->irq);
 }
 
 /*
@@ -630,7 +632,6 @@ out:
 	spin_unlock_irqrestore(&host->complete_lock, iflags);
 	return;
 
-
 fail_request:
 	host->mrq->data->error = -EINVAL;
 	host->complete_what = COMPLETION_FINALIZE;

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

  parent reply	other threads:[~2008-06-30 15:28 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 15:25 [patch v4 00/17] S3C24XX SD/MMC maintainer Ben Dooks
2008-06-30 15:25 ` [patch v4 01/17] MMC: S3C24XX MMC/SD driver Ben Dooks
2008-06-30 15:25 ` [patch v4 02/17] MMC: S3C24XX: Fix the checkpatch.pl errors in the s3cmci driver Ben Dooks
2008-06-30 15:50   ` Pierre Ossman
2008-06-30 16:15     ` Ben Dooks
2008-06-30 16:36       ` Harald Welte
2008-06-30 17:02         ` Thomas Kleffel
2008-06-30 17:31           ` Ben Dooks
2008-06-30 17:04         ` Ben Dooks
2008-06-30 18:10           ` Pierre Ossman
2008-06-30 19:07             ` Ben Dooks
2008-06-30 15:25 ` [patch v4 03/17] MMC: S3C24XX MMC/SD driver write fixes Ben Dooks
2008-06-30 15:25 ` [patch v4 04/17] MMC: DMA free fix for S3C24XX SD/MMC driver Ben Dooks
2008-06-30 15:25 ` [patch v4 05/17] MMC: S3C24XX MMC/SD stop fix Ben Dooks
2008-06-30 15:25 ` Ben Dooks [this message]
2008-06-30 15:25 ` [patch v4 07/17] MMC: S3C24XX: Add platform data for MMC/SD driver Ben Dooks
2008-06-30 15:25 ` [patch v4 08/17] MMC: S3C24XX: Add support to invert write protect line Ben Dooks
2008-06-30 15:25 ` [patch v4 09/17] MMC: S3C24XX: Ensure host->mrq->data is valid Ben Dooks
2008-06-30 15:25 ` [patch v4 10/17] MMC: S3C24XX: Allow card-detect on non-IRQ capable pin Ben Dooks
2008-06-30 15:25 ` [patch v4 11/17] MMC: S3C24XX: Fix s3c2410_dma_request() return code check Ben Dooks
2008-06-30 15:25 ` [patch v4 12/17] MMC: S3C24XX: Add MODULE_ALIAS() entries for the platform devices Ben Dooks
2008-06-30 15:26 ` [patch v4 13/17] MMC: S3C24XX: Fix use of msecs where jiffies are needed Ben Dooks
2008-06-30 15:26 ` [patch v4 14/17] MMC: S3C24XX: Add media presence test to request handling Ben Dooks
2008-06-30 15:26 ` [patch v4 15/17] MMC: S3C24XX: Update error debugging Ben Dooks
2008-06-30 15:26 ` [patch v4 16/17] MMC: S3C24XX: Add maintainer entry Ben Dooks
2008-06-30 15:26 ` [patch v4 17/17] MMC: S3C24XX: Ben Dooks
2008-06-30 15:36   ` Ben Dooks
2008-06-30 15:50     ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080630152747.966770291@fluff.org.uk \
    --to=ben-linux@fluff.org \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=laforge@openmoko.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tk@maintech.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®