mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Ben Dooks <ben-linux@fluff.org>
To: linux-kernel@vger.kernel.org, drzeus-mmc@drzeus.cx
Cc: tk@maintech.de, laforge@openmoko.org, Ben Dooks <ben-linux@fluff.org>
Subject: [patch v4 14/17] MMC: S3C24XX: Add media presence test to request handling.
Date: Mon, 30 Jun 2008 16:26:01 +0100	[thread overview]
Message-ID: <20080630152749.795735357@fluff.org.uk> (raw)
In-Reply-To: <20080630152547.755285683@fluff.org.uk>

[-- Attachment #1: simtec/s3c24xx-sdmmc-add-mediacheck.patch --]
[-- Type: text/plain, Size: 2127 bytes --]

Ensure that we have physical media present before attempting to
send a request to a card. This ensures that we do not get flooded
by errors from commands that can never be completed timing out.

Signed-off-by: Ben Dooks <ben-linux@fluff.org>

Index: linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c
===================================================================
--- linux-2.6.26-rc8-next20080627.orig/drivers/mmc/host/s3cmci.c	2008-06-30 12:36:57.000000000 +0100
+++ linux-2.6.26-rc8-next20080627/drivers/mmc/host/s3cmci.c	2008-06-30 15:23:42.000000000 +0100
@@ -984,6 +984,18 @@ static void s3cmci_send_request(struct m
 	enable_irq(host->irq);
 }
 
+static int s3cmci_card_present(struct s3cmci_host *host)
+{
+	struct s3c24xx_mci_pdata *pdata = host->pdata;
+	int ret;
+
+	if (pdata->gpio_detect == 0)
+		return -ENOSYS;
+
+	ret = s3c2410_gpio_getpin(pdata->gpio_detect) ? 0 : 1;
+	return ret ^ pdata->detect_invert;
+}
+
 static void s3cmci_request(struct mmc_host *mmc, struct mmc_request *mrq)
 {
 	struct s3cmci_host *host = mmc_priv(mmc);
@@ -992,7 +1004,12 @@ static void s3cmci_request(struct mmc_ho
 	host->cmd_is_stop = 0;
 	host->mrq = mrq;
 
-	s3cmci_send_request(mmc);
+	if (s3cmci_card_present(host) == 0) {
+		dbg(host, dbg_err, "%s: no medium present\n", __func__);
+		host->mrq->cmd->error = -ENOMEDIUM;
+		mmc_request_done(mmc, mrq);
+	} else
+		s3cmci_send_request(mmc);
 }
 
 static void s3cmci_set_ios(struct mmc_host *mmc, struct mmc_ios *ios)
Index: linux-2.6.26-rc8-next20080627/include/asm-arm/plat-s3c24xx/mci.h
===================================================================
--- linux-2.6.26-rc8-next20080627.orig/include/asm-arm/plat-s3c24xx/mci.h	2008-06-30 12:36:42.000000000 +0100
+++ linux-2.6.26-rc8-next20080627/include/asm-arm/plat-s3c24xx/mci.h	2008-06-30 12:37:19.000000000 +0100
@@ -3,6 +3,7 @@
 
 struct s3c24xx_mci_pdata {
 	unsigned int	wprotect_invert : 1;
+	unsigned int	detect_invert : 1;   /* set => detect active high. */
 
 	unsigned int	gpio_detect;
 	unsigned int	gpio_wprotect;

-- 
Ben (ben@fluff.org, http://www.fluff.org/)

  'a smiley only costs 4 bytes'

  parent reply	other threads:[~2008-06-30 15:30 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-06-30 15:25 [patch v4 00/17] S3C24XX SD/MMC maintainer Ben Dooks
2008-06-30 15:25 ` [patch v4 01/17] MMC: S3C24XX MMC/SD driver Ben Dooks
2008-06-30 15:25 ` [patch v4 02/17] MMC: S3C24XX: Fix the checkpatch.pl errors in the s3cmci driver Ben Dooks
2008-06-30 15:50   ` Pierre Ossman
2008-06-30 16:15     ` Ben Dooks
2008-06-30 16:36       ` Harald Welte
2008-06-30 17:02         ` Thomas Kleffel
2008-06-30 17:31           ` Ben Dooks
2008-06-30 17:04         ` Ben Dooks
2008-06-30 18:10           ` Pierre Ossman
2008-06-30 19:07             ` Ben Dooks
2008-06-30 15:25 ` [patch v4 03/17] MMC: S3C24XX MMC/SD driver write fixes Ben Dooks
2008-06-30 15:25 ` [patch v4 04/17] MMC: DMA free fix for S3C24XX SD/MMC driver Ben Dooks
2008-06-30 15:25 ` [patch v4 05/17] MMC: S3C24XX MMC/SD stop fix Ben Dooks
2008-06-30 15:25 ` [patch v4 06/17] MMC: Fix S3C24XX IRQ enable during PIO transfers Ben Dooks
2008-06-30 15:25 ` [patch v4 07/17] MMC: S3C24XX: Add platform data for MMC/SD driver Ben Dooks
2008-06-30 15:25 ` [patch v4 08/17] MMC: S3C24XX: Add support to invert write protect line Ben Dooks
2008-06-30 15:25 ` [patch v4 09/17] MMC: S3C24XX: Ensure host->mrq->data is valid Ben Dooks
2008-06-30 15:25 ` [patch v4 10/17] MMC: S3C24XX: Allow card-detect on non-IRQ capable pin Ben Dooks
2008-06-30 15:25 ` [patch v4 11/17] MMC: S3C24XX: Fix s3c2410_dma_request() return code check Ben Dooks
2008-06-30 15:25 ` [patch v4 12/17] MMC: S3C24XX: Add MODULE_ALIAS() entries for the platform devices Ben Dooks
2008-06-30 15:26 ` [patch v4 13/17] MMC: S3C24XX: Fix use of msecs where jiffies are needed Ben Dooks
2008-06-30 15:26 ` Ben Dooks [this message]
2008-06-30 15:26 ` [patch v4 15/17] MMC: S3C24XX: Update error debugging Ben Dooks
2008-06-30 15:26 ` [patch v4 16/17] MMC: S3C24XX: Add maintainer entry Ben Dooks
2008-06-30 15:26 ` [patch v4 17/17] MMC: S3C24XX: Ben Dooks
2008-06-30 15:36   ` Ben Dooks
2008-06-30 15:50     ` Pierre Ossman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20080630152749.795735357@fluff.org.uk \
    --to=ben-linux@fluff.org \
    --cc=drzeus-mmc@drzeus.cx \
    --cc=laforge@openmoko.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tk@maintech.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®