From: Yinghai Lu <yhlu.kernel@gmail.com>
To: Ingo Molnar <mingo@elte.hu>, Thomas Gleixner <tglx@linutronix.de>,
"H. Peter Anvin" <hpa@zytor.com>,
Suresh Siddha <suresh.b.siddha@intel.com>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] x86: max_low_pfn_mapped fix #2
Date: Sat, 12 Jul 2008 14:31:28 -0700 [thread overview]
Message-ID: <200807121431.28725.yhlu.kernel@gmail.com> (raw)
In-Reply-To: <200807102038.26591.yhlu.kernel@gmail.com>
tight the boundary check
also print out tseg for amd cpu.
Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>
---
arch/x86/kernel/cpu/amd_64.c | 1 +
arch/x86/mm/pageattr.c | 4 ++--
arch/x86/mm/pat.c | 4 ++--
arch/x86/pci/i386.c | 4 ++--
4 files changed, 7 insertions(+), 6 deletions(-)
Index: linux-2.6/arch/x86/kernel/cpu/amd_64.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/cpu/amd_64.c
+++ linux-2.6/arch/x86/kernel/cpu/amd_64.c
@@ -200,6 +200,7 @@ static void __cpuinit init_amd(struct cp
* benefit in doing so.
*/
if (!rdmsrl_safe(MSR_K8_TSEG_ADDR, &tseg)) {
+ printk(KERN_DEBUG "tseg: %010llx\n", tseg);
if ((tseg>>PMD_SHIFT) <
(max_low_pfn_mapped>>(PMD_SHIFT-PAGE_SHIFT)) ||
((tseg>>PMD_SHIFT) <
Index: linux-2.6/arch/x86/mm/pageattr.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/pageattr.c
+++ linux-2.6/arch/x86/mm/pageattr.c
@@ -658,11 +658,11 @@ static int cpa_process_alias(struct cpa_
struct cpa_data alias_cpa;
int ret = 0;
- if (cpa->pfn > max_pfn_mapped)
+ if (cpa->pfn >= max_pfn_mapped)
return 0;
#ifdef CONFIG_X86_64
- if (cpa->pfn > max_low_pfn_mapped && cpa->pfn < (1UL<<(32-PAGE_SHIFT)))
+ if (cpa->pfn >= max_low_pfn_mapped && cpa->pfn < (1UL<<(32-PAGE_SHIFT)))
return 0;
#endif
/*
Index: linux-2.6/arch/x86/mm/pat.c
===================================================================
--- linux-2.6.orig/arch/x86/mm/pat.c
+++ linux-2.6/arch/x86/mm/pat.c
@@ -449,8 +449,8 @@ int phys_mem_access_prot_allowed(struct
if (retval < 0)
return 0;
- if (((pfn <= max_low_pfn_mapped) ||
- (pfn >= (1UL<<(32 - PAGE_SHIFT)) && pfn <= max_pfn_mapped)) &&
+ if (((pfn < max_low_pfn_mapped) ||
+ (pfn >= (1UL<<(32 - PAGE_SHIFT)) && pfn < max_pfn_mapped)) &&
ioremap_change_attr((unsigned long)__va(offset), size, flags) < 0) {
free_memtype(offset, offset + size);
printk(KERN_INFO
Index: linux-2.6/arch/x86/pci/i386.c
===================================================================
--- linux-2.6.orig/arch/x86/pci/i386.c
+++ linux-2.6/arch/x86/pci/i386.c
@@ -334,9 +334,9 @@ int pci_mmap_page_range(struct pci_dev *
flags = new_flags;
}
- if (((vma->vm_pgoff <= max_low_pfn_mapped) ||
+ if (((vma->vm_pgoff < max_low_pfn_mapped) ||
(vma->vm_pgoff >= (1UL<<(32 - PAGE_SHIFT)) &&
- vma->vm_pgoff <= max_pfn_mapped)) &&
+ vma->vm_pgoff < max_pfn_mapped)) &&
ioremap_change_attr((unsigned long)__va(addr), len, flags)) {
free_memtype(addr, addr + len);
return -EINVAL;
next prev parent reply other threads:[~2008-07-12 21:33 UTC|newest]
Thread overview: 84+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-08 8:41 [PATCH] x86: introduce page_size_mask for 64bit Yinghai Lu
2008-07-08 8:43 ` [PATCH] x86: not overmap than end in init_memory_mapping - 64bit Yinghai Lu
2008-07-09 7:38 ` Ingo Molnar
2008-07-09 8:34 ` Ingo Molnar
2008-07-09 8:37 ` Yinghai Lu
2008-07-09 8:46 ` Ingo Molnar
2008-07-09 8:58 ` Yinghai Lu
2008-07-09 10:01 ` Yinghai Lu
2008-07-09 10:30 ` Ingo Molnar
2008-07-09 8:45 ` Ingo Molnar
2008-07-10 3:15 ` [PATCh] x86: overmapped fix when 4K pages on tail " Yinghai Lu
2008-07-10 3:16 ` [PATCH] x86: merge __acpi_map_table Yinghai Lu
2008-07-10 3:17 ` [PATCH] x86: make e820_end return end_of_ram again for 64bit Yinghai Lu
2008-07-10 7:00 ` Ingo Molnar
2008-07-10 11:17 ` [PATCH] x86: e820 remove the range instead of update it to reserved Yinghai Lu
2008-07-11 8:20 ` Ingo Molnar
2008-07-11 3:36 ` [PATCH] x86: save slit Yinghai Lu
2008-07-11 8:22 ` Ingo Molnar
2008-07-11 3:38 ` [PATCH] x86: introduce max_low_pfn_mapped for 64bit Yinghai Lu
2008-07-11 8:26 ` Ingo Molnar
2008-07-11 8:39 ` Yinghai Lu
2008-07-11 8:51 ` Ingo Molnar
2008-07-12 1:41 ` [PATCH] x86: let 32bit use apic_ops too Yinghai Lu
2008-07-12 1:43 ` [PATCH] x86: mach_apicdef.h need to include before smp.h Yinghai Lu
2008-07-12 1:44 ` [PATCH] x86: make read_apic_id return final apicid Yinghai Lu
2008-07-12 8:01 ` [PATCH] x86: make 64bit have get_apic_id Yinghai Lu
2008-07-13 6:28 ` Ingo Molnar
2008-07-13 6:59 ` Ingo Molnar
2008-07-13 7:05 ` Yinghai Lu
2008-07-13 9:23 ` Ingo Molnar
2008-07-13 9:28 ` Ingo Molnar
2008-07-13 16:15 ` Suresh Siddha
2008-07-13 1:19 ` [PATCH] x86: make read_apic_id return final apicid Suresh Siddha
2008-07-13 1:08 ` [PATCH] x86: let 32bit use apic_ops too Suresh Siddha
2008-07-13 2:04 ` Yinghai Lu
2008-07-13 16:28 ` Suresh Siddha
2008-07-13 16:51 ` Maciej W. Rozycki
2008-07-13 17:16 ` Cyrill Gorcunov
2008-07-13 23:46 ` Maciej W. Rozycki
2008-07-14 16:48 ` Cyrill Gorcunov
2008-07-14 17:20 ` Maciej W. Rozycki
2008-07-14 18:09 ` Cyrill Gorcunov
2008-07-14 18:24 ` Maciej W. Rozycki
2008-07-14 18:32 ` Cyrill Gorcunov
2008-07-13 1:43 ` Maciej W. Rozycki
2008-07-13 1:45 ` Yinghai Lu
2008-07-13 1:54 ` Maciej W. Rozycki
2008-07-13 16:43 ` Suresh Siddha
2008-07-13 17:05 ` Maciej W. Rozycki
2008-07-14 5:19 ` [PATCH] x86: let 32bit use apic_ops too - fix Yinghai Lu
2008-07-14 7:12 ` Ingo Molnar
2008-07-14 16:49 ` Suresh Siddha
2008-07-14 17:00 ` Yinghai Lu
2008-07-14 18:03 ` Suresh Siddha
2008-07-18 17:06 ` Ingo Molnar
2008-07-15 17:33 ` Suresh Siddha
2008-07-15 18:10 ` Yinghai Lu
2008-07-15 18:27 ` Suresh Siddha
2008-07-18 17:07 ` Ingo Molnar
2008-07-12 21:30 ` [PATCH] x86: max_low_pfn_mapped fix #1 Yinghai Lu
2008-07-13 9:45 ` Ingo Molnar
2008-07-12 21:31 ` Yinghai Lu [this message]
2008-07-12 21:32 ` [PATCH] x86: max_low_pfn_mapped fix #3 Yinghai Lu
2008-07-13 21:29 ` [PATCH] x86: max_low_pfn_mapped fix #4 Yinghai Lu
2008-07-13 21:30 ` [PATCH] x86: get x86_phys_bits early Yinghai Lu
2008-07-13 21:32 ` [PATCH] x86: make 64bit hpet_set_mapping to use ioremap too Yinghai Lu
2008-07-13 21:50 ` [PATCH] x86: make 64bit hpet_set_mapping to use ioremap too v2 Yinghai Lu
2008-07-10 6:54 ` [PATCH] x86: merge __acpi_map_table Ingo Molnar
2008-07-10 6:53 ` [PATCh] x86: overmapped fix when 4K pages on tail - 64bit Ingo Molnar
2008-07-10 6:57 ` Yinghai Lu
2008-07-10 7:20 ` Ingo Molnar
2008-07-10 7:32 ` Yinghai Lu
2008-07-10 14:16 ` Arjan van de Ven
2008-07-13 14:57 ` Andi Kleen
2008-07-13 15:33 ` Arjan van de Ven
2008-07-13 18:25 ` Andi Kleen
2008-07-13 18:17 ` Yinghai Lu
2008-07-13 18:48 ` Andi Kleen
2008-07-13 19:00 ` Yinghai Lu
2008-07-13 20:32 ` Ingo Molnar
2008-07-13 20:51 ` Andi Kleen
2008-07-14 0:04 ` H. Peter Anvin
2008-07-14 6:39 ` Andi Kleen
2008-07-09 7:38 ` [PATCH] x86: introduce page_size_mask for 64bit Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200807121431.28725.yhlu.kernel@gmail.com \
--to=yhlu.kernel@gmail.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=suresh.b.siddha@intel.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome