mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Yinghai Lu" <yhlu.kernel@gmail.com>
To: "Ingo Molnar" <mingo@elte.hu>
Cc: "Thomas Gleixner" <tglx@linutronix.de>,
	"H. Peter Anvin" <hpa@zytor.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] x86: not overmap than end in init_memory_mapping - 64bit
Date: Wed, 9 Jul 2008 03:01:14 -0700	[thread overview]
Message-ID: <86802c440807090301k774d15cdj9aab256bae0ffe7@mail.gmail.com> (raw)
In-Reply-To: <20080709084600.GA4919@elte.hu>

[-- Attachment #1: Type: text/plain, Size: 470 bytes --]

On Wed, Jul 9, 2008 at 1:46 AM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Yinghai Lu <yhlu.kernel@gmail.com> wrote:
>
>> > reverting the commit solves the crash. The crash seems to be because
>> > ACPI is unable to access that memory range. (perhaps early_ioremap
>> > fails?)
>>
>> system with less than 4g?
>
> yeah.
>
>> please test attached patch
>> [PATCH] x86: make max_pfn cover acpi table below 4g
>
> that fixed it, thanks.

please check fix for 32 bit too.

YH

[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: e820_end_32.patch --]
[-- Type: text/x-patch; name=e820_end_32.patch, Size: 746 bytes --]

[PATCH] x86: make e820_end return max ram type only for 32 bit

to avoid warning from find_low_pfn_range for high pages size etc

Signed-off-by: Yinghai Lu <yhlu.kernel@gmail.com>

---
 arch/x86/kernel/e820.c |    5 +++++
 1 file changed, 5 insertions(+)

Index: linux-2.6/arch/x86/kernel/e820.c
===================================================================
--- linux-2.6.orig/arch/x86/kernel/e820.c
+++ linux-2.6/arch/x86/kernel/e820.c
@@ -1066,6 +1066,11 @@ unsigned long __init e820_end(void)
 		struct e820entry *ei = &e820.map[i];
 		unsigned long end_pfn;
 
+#ifdef CONFIG_X86_32
+		if (ei->type != E820_RAM)
+			continue;
+#endif
+
 		end_pfn = (ei->addr + ei->size) >> PAGE_SHIFT;
 		if (end_pfn > last_pfn)
 			last_pfn = end_pfn;

  parent reply	other threads:[~2008-07-09 10:01 UTC|newest]

Thread overview: 84+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-07-08  8:41 [PATCH] x86: introduce page_size_mask for 64bit Yinghai Lu
2008-07-08  8:43 ` [PATCH] x86: not overmap than end in init_memory_mapping - 64bit Yinghai Lu
2008-07-09  7:38   ` Ingo Molnar
2008-07-09  8:34     ` Ingo Molnar
2008-07-09  8:37       ` Yinghai Lu
2008-07-09  8:46         ` Ingo Molnar
2008-07-09  8:58           ` Yinghai Lu
2008-07-09 10:01           ` Yinghai Lu [this message]
2008-07-09 10:30             ` Ingo Molnar
2008-07-09  8:45       ` Ingo Molnar
2008-07-10  3:15   ` [PATCh] x86: overmapped fix when 4K pages on tail " Yinghai Lu
2008-07-10  3:16     ` [PATCH] x86: merge __acpi_map_table Yinghai Lu
2008-07-10  3:17       ` [PATCH] x86: make e820_end return end_of_ram again for 64bit Yinghai Lu
2008-07-10  7:00         ` Ingo Molnar
2008-07-10 11:17         ` [PATCH] x86: e820 remove the range instead of update it to reserved Yinghai Lu
2008-07-11  8:20           ` Ingo Molnar
2008-07-11  3:36         ` [PATCH] x86: save slit Yinghai Lu
2008-07-11  8:22           ` Ingo Molnar
2008-07-11  3:38         ` [PATCH] x86: introduce max_low_pfn_mapped for 64bit Yinghai Lu
2008-07-11  8:26           ` Ingo Molnar
2008-07-11  8:39             ` Yinghai Lu
2008-07-11  8:51               ` Ingo Molnar
2008-07-12  1:41           ` [PATCH] x86: let 32bit use apic_ops too Yinghai Lu
2008-07-12  1:43             ` [PATCH] x86: mach_apicdef.h need to include before smp.h Yinghai Lu
2008-07-12  1:44               ` [PATCH] x86: make read_apic_id return final apicid Yinghai Lu
2008-07-12  8:01                 ` [PATCH] x86: make 64bit have get_apic_id Yinghai Lu
2008-07-13  6:28                   ` Ingo Molnar
2008-07-13  6:59                     ` Ingo Molnar
2008-07-13  7:05                       ` Yinghai Lu
2008-07-13  9:23                         ` Ingo Molnar
2008-07-13  9:28                           ` Ingo Molnar
2008-07-13 16:15                             ` Suresh Siddha
2008-07-13  1:19                 ` [PATCH] x86: make read_apic_id return final apicid Suresh Siddha
2008-07-13  1:08             ` [PATCH] x86: let 32bit use apic_ops too Suresh Siddha
2008-07-13  2:04               ` Yinghai Lu
2008-07-13 16:28                 ` Suresh Siddha
2008-07-13 16:51                   ` Maciej W. Rozycki
2008-07-13 17:16                     ` Cyrill Gorcunov
2008-07-13 23:46                       ` Maciej W. Rozycki
2008-07-14 16:48                         ` Cyrill Gorcunov
2008-07-14 17:20                           ` Maciej W. Rozycki
2008-07-14 18:09                             ` Cyrill Gorcunov
2008-07-14 18:24                               ` Maciej W. Rozycki
2008-07-14 18:32                                 ` Cyrill Gorcunov
2008-07-13  1:43             ` Maciej W. Rozycki
2008-07-13  1:45               ` Yinghai Lu
2008-07-13  1:54                 ` Maciej W. Rozycki
2008-07-13 16:43                   ` Suresh Siddha
2008-07-13 17:05                     ` Maciej W. Rozycki
2008-07-14  5:19             ` [PATCH] x86: let 32bit use apic_ops too - fix Yinghai Lu
2008-07-14  7:12               ` Ingo Molnar
2008-07-14 16:49                 ` Suresh Siddha
2008-07-14 17:00                   ` Yinghai Lu
2008-07-14 18:03                     ` Suresh Siddha
2008-07-18 17:06                   ` Ingo Molnar
2008-07-15 17:33               ` Suresh Siddha
2008-07-15 18:10                 ` Yinghai Lu
2008-07-15 18:27                   ` Suresh Siddha
2008-07-18 17:07                 ` Ingo Molnar
2008-07-12 21:30           ` [PATCH] x86: max_low_pfn_mapped fix #1 Yinghai Lu
2008-07-13  9:45             ` Ingo Molnar
2008-07-12 21:31           ` [PATCH] x86: max_low_pfn_mapped fix #2 Yinghai Lu
2008-07-12 21:32           ` [PATCH] x86: max_low_pfn_mapped fix #3 Yinghai Lu
2008-07-13 21:29             ` [PATCH] x86: max_low_pfn_mapped fix #4 Yinghai Lu
2008-07-13 21:30             ` [PATCH] x86: get x86_phys_bits early Yinghai Lu
2008-07-13 21:32             ` [PATCH] x86: make 64bit hpet_set_mapping to use ioremap too Yinghai Lu
2008-07-13 21:50               ` [PATCH] x86: make 64bit hpet_set_mapping to use ioremap too v2 Yinghai Lu
2008-07-10  6:54       ` [PATCH] x86: merge __acpi_map_table Ingo Molnar
2008-07-10  6:53     ` [PATCh] x86: overmapped fix when 4K pages on tail - 64bit Ingo Molnar
2008-07-10  6:57       ` Yinghai Lu
2008-07-10  7:20         ` Ingo Molnar
2008-07-10  7:32           ` Yinghai Lu
2008-07-10 14:16     ` Arjan van de Ven
2008-07-13 14:57       ` Andi Kleen
2008-07-13 15:33         ` Arjan van de Ven
2008-07-13 18:25           ` Andi Kleen
2008-07-13 18:17         ` Yinghai Lu
2008-07-13 18:48           ` Andi Kleen
2008-07-13 19:00             ` Yinghai Lu
2008-07-13 20:32             ` Ingo Molnar
2008-07-13 20:51               ` Andi Kleen
2008-07-14  0:04                 ` H. Peter Anvin
2008-07-14  6:39                   ` Andi Kleen
2008-07-09  7:38 ` [PATCH] x86: introduce page_size_mask for 64bit Ingo Molnar

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=86802c440807090301k774d15cdj9aab256bae0ffe7@mail.gmail.com \
    --to=yhlu.kernel@gmail.com \
    --cc=hpa@zytor.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®