mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [mmotm] pm: fix build error
@ 2008-07-14  7:23 KOSAKI Motohiro
  2008-07-14  7:34 ` Pavel Machek
  0 siblings, 1 reply; 2+ messages in thread
From: KOSAKI Motohiro @ 2008-07-14  7:23 UTC (permalink / raw)
  To: Zhang Rui, Rus, Rafael J. Wysocki, Pavel Machek, Andrew Morton, LKML
  Cc: kosaki.motohiro

Hi

My IA64 machine can't build on today's mmotm(Jul 13).
So, below patch is necessary, I think.

----------------------------------------------------
Against: mmotm, Jul 13
Applies after: pm-schedule-sysrq-poweroff-on-boot-cpu.patch

Now, handle_poweroff() use cpu_online_map variable.
So cpumask.h sould be included.
Otherwise it cause following build error on ia64 (I guess also sevaral othor platfom).

	kernel/power/poweroff.c: In function 'handle_poweroff':
	kernel/power/poweroff.c:29: error: implicit declaration of function 'first_cpu'
	kernel/power/poweroff.c:29: error: 'cpu_online_map' undeclared (first use in this function)
	kernel/power/poweroff.c:29: error: (Each undeclared identifier is reported only once
	kernel/power/poweroff.c:29: error: for each function it appears in.)
	make[2]: *** [kernel/power/poweroff.o] Error 1
	make[1]: *** [kernel/power] Error 2


Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
CC: Zhang Rui <rui.zhang@intel.com>
CC: Rus <harbour@sfinx.od.ua>
CC: Rafael J. Wysocki <rjw@sisk.pl>
CC: Pavel Machek <pavel@ucw.cz>

---
 kernel/power/poweroff.c |    1 +
 1 file changed, 1 insertion(+)

Index: b/kernel/power/poweroff.c
===================================================================
--- a/kernel/power/poweroff.c
+++ b/kernel/power/poweroff.c
@@ -10,6 +10,7 @@
 #include <linux/pm.h>
 #include <linux/workqueue.h>
 #include <linux/reboot.h>
+#include <linux/cpumask.h>
 
 /*
  * When the user hits Sys-Rq o to power down the machine this is the



^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [mmotm] pm: fix build error
  2008-07-14  7:23 [mmotm] pm: fix build error KOSAKI Motohiro
@ 2008-07-14  7:34 ` Pavel Machek
  0 siblings, 0 replies; 2+ messages in thread
From: Pavel Machek @ 2008-07-14  7:34 UTC (permalink / raw)
  To: KOSAKI Motohiro; +Cc: Zhang Rui, Rus, Rafael J. Wysocki, Andrew Morton, LKML

Hi!

> My IA64 machine can't build on today's mmotm(Jul 13).
> So, below patch is necessary, I think.
> 
> ----------------------------------------------------
> Against: mmotm, Jul 13
> Applies after: pm-schedule-sysrq-poweroff-on-boot-cpu.patch
> 
> Now, handle_poweroff() use cpu_online_map variable.
> So cpumask.h sould be included.
> Otherwise it cause following build error on ia64 (I guess also sevaral othor platfom).
> 
> 	kernel/power/poweroff.c: In function 'handle_poweroff':
> 	kernel/power/poweroff.c:29: error: implicit declaration of function 'first_cpu'
> 	kernel/power/poweroff.c:29: error: 'cpu_online_map' undeclared (first use in this function)
> 	kernel/power/poweroff.c:29: error: (Each undeclared identifier is reported only once
> 	kernel/power/poweroff.c:29: error: for each function it appears in.)
> 	make[2]: *** [kernel/power/poweroff.o] Error 1
> 	make[1]: *** [kernel/power] Error 2
> 
> 
> Signed-off-by: KOSAKI Motohiro <kosaki.motohiro@jp.fujitsu.com>
> CC: Zhang Rui <rui.zhang@intel.com>
> CC: Rus <harbour@sfinx.od.ua>
> CC: Rafael J. Wysocki <rjw@sisk.pl>
> CC: Pavel Machek <pavel@ucw.cz>

ACK.

> ---
>  kernel/power/poweroff.c |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: b/kernel/power/poweroff.c
> ===================================================================
> --- a/kernel/power/poweroff.c
> +++ b/kernel/power/poweroff.c
> @@ -10,6 +10,7 @@
>  #include <linux/pm.h>
>  #include <linux/workqueue.h>
>  #include <linux/reboot.h>
> +#include <linux/cpumask.h>
>  
>  /*
>   * When the user hits Sys-Rq o to power down the machine this is the
> 

-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-07-14  7:33 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-14  7:23 [mmotm] pm: fix build error KOSAKI Motohiro
2008-07-14  7:34 ` Pavel Machek

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®