From: Ingo Molnar <mingo@elte.hu>
To: Suresh Siddha <suresh.b.siddha@intel.com>
Cc: Yinghai Lu <yhlu.kernel@gmail.com>,
Zachary Amsden <zach@vmware.com>,
"Maciej W. Rozycki" <macro@linux-mips.org>,
"x86@kernel.org" <x86@kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Jeremy Fitzhardinge <jeremy@goop.org>
Subject: Re: [PATCH] x86: APIC: Remove apic_write_around(); use alternatives
Date: Sun, 20 Jul 2008 17:04:44 +0200 [thread overview]
Message-ID: <20080720150444.GA4225@elte.hu> (raw)
In-Reply-To: <20080720120811.GA16138@elte.hu>
* Ingo Molnar <mingo@elte.hu> wrote:
> i've merged tip/x86/x2apic into tip/master, and it seems to be working
> fine. One UP build fix was needed for Xen, see below.
and a similar one for UP lguest.
Ingo
---------------->
commit 7be42004065ce4df193aeef5befd26805267d0d9
Author: Ingo Molnar <mingo@elte.hu>
Date: Sun Jul 20 17:04:57 2008 +0200
x86, lguest: fix apic_ops build on UP
fix:
arch/x86/lguest/boot.c:816: error: variable ‘lguest_basic_apic_ops’ has initializer but incomplete type
arch/x86/lguest/boot.c:817: error: unknown field ‘read’ specified in initializer
[...]
Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
arch/x86/lguest/boot.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/arch/x86/lguest/boot.c b/arch/x86/lguest/boot.c
index 35c4349..756fc48 100644
--- a/arch/x86/lguest/boot.c
+++ b/arch/x86/lguest/boot.c
@@ -55,6 +55,7 @@
#include <linux/lguest_launcher.h>
#include <linux/virtio_console.h>
#include <linux/pm.h>
+#include <asm/apic.h>
#include <asm/lguest.h>
#include <asm/paravirt.h>
#include <asm/param.h>
next prev parent reply other threads:[~2008-07-20 15:05 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-07-16 18:15 Maciej W. Rozycki
2008-07-18 10:52 ` Ingo Molnar
2008-07-18 16:25 ` Yinghai Lu
2008-07-18 17:01 ` Yinghai Lu
2008-07-18 21:03 ` Ingo Molnar
2008-07-18 21:13 ` Yinghai Lu
2008-07-18 22:02 ` Maciej W. Rozycki
2008-07-18 22:42 ` Zachary Amsden
2008-07-18 22:49 ` Suresh Siddha
2008-07-18 22:51 ` Yinghai Lu
2008-07-18 23:00 ` Suresh Siddha
2008-07-18 23:04 ` Yinghai Lu
2008-07-18 23:18 ` Suresh Siddha
2008-07-19 21:49 ` Ingo Molnar
2008-07-19 21:53 ` Ingo Molnar
2008-07-20 12:08 ` Ingo Molnar
2008-07-20 15:04 ` Ingo Molnar [this message]
2008-07-21 17:59 ` Suresh Siddha
2008-07-22 13:24 ` Yong Wang
2008-07-22 13:48 ` Ingo Molnar
2008-07-18 23:43 ` Zachary Amsden
2008-07-19 21:43 ` Ingo Molnar
2008-07-18 22:58 ` Suresh Siddha
2008-07-19 21:47 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080720150444.GA4225@elte.hu \
--to=mingo@elte.hu \
--cc=jeremy@goop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=macro@linux-mips.org \
--cc=suresh.b.siddha@intel.com \
--cc=x86@kernel.org \
--cc=yhlu.kernel@gmail.com \
--cc=zach@vmware.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome