* [PATCH -next] kmemcheck: include module.h to prevent warnings
@ 2008-07-24 23:09 Randy Dunlap
2008-07-24 23:27 ` Pekka Enberg
2008-07-26 15:43 ` Ingo Molnar
0 siblings, 2 replies; 4+ messages in thread
From: Randy Dunlap @ 2008-07-24 23:09 UTC (permalink / raw)
To: lkml; +Cc: vegardno, penberg, akpm
From: Randy Dunlap <randy.dunlap@oracle.com>
kmemcheck/shadow.c needs to include <linux/module.h> to prevent
the following warnings:
linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class
linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration
Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
---
arch/x86/mm/kmemcheck/shadow.c | 1 +
1 file changed, 1 insertion(+)
--- linux-next-20080724.orig/arch/x86/mm/kmemcheck/shadow.c
+++ linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c
@@ -1,5 +1,6 @@
#include <linux/kmemcheck.h>
#include <linux/mm.h>
+#include <linux/module.h>
#include <asm/page.h>
#include <asm/pgtable.h>
---
~Randy
Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
http://linuxplumbersconf.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] kmemcheck: include module.h to prevent warnings
2008-07-24 23:09 [PATCH -next] kmemcheck: include module.h to prevent warnings Randy Dunlap
@ 2008-07-24 23:27 ` Pekka Enberg
2008-07-26 15:43 ` Ingo Molnar
1 sibling, 0 replies; 4+ messages in thread
From: Pekka Enberg @ 2008-07-24 23:27 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, vegardno, akpm
On Thu, 2008-07-24 at 16:09 -0700, Randy Dunlap wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> kmemcheck/shadow.c needs to include <linux/module.h> to prevent
> the following warnings:
>
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
Looks good to me.
Acked-by: Pekka Enberg <penberg@cs.helsinki.fi>
> ---
> arch/x86/mm/kmemcheck/shadow.c | 1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-next-20080724.orig/arch/x86/mm/kmemcheck/shadow.c
> +++ linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c
> @@ -1,5 +1,6 @@
> #include <linux/kmemcheck.h>
> #include <linux/mm.h>
> +#include <linux/module.h>
>
> #include <asm/page.h>
> #include <asm/pgtable.h>
>
>
> ---
> ~Randy
> Linux Plumbers Conference, 17-19 September 2008, Portland, Oregon USA
> http://linuxplumbersconf.org/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] kmemcheck: include module.h to prevent warnings
2008-07-24 23:09 [PATCH -next] kmemcheck: include module.h to prevent warnings Randy Dunlap
2008-07-24 23:27 ` Pekka Enberg
@ 2008-07-26 15:43 ` Ingo Molnar
2008-07-26 18:28 ` Vegard Nossum
1 sibling, 1 reply; 4+ messages in thread
From: Ingo Molnar @ 2008-07-26 15:43 UTC (permalink / raw)
To: Randy Dunlap; +Cc: lkml, vegardno, penberg, akpm
* Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> kmemcheck/shadow.c needs to include <linux/module.h> to prevent
> the following warnings:
>
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration
applied to tip/kmemcheck - thanks Randy.
Ingo
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH -next] kmemcheck: include module.h to prevent warnings
2008-07-26 15:43 ` Ingo Molnar
@ 2008-07-26 18:28 ` Vegard Nossum
0 siblings, 0 replies; 4+ messages in thread
From: Vegard Nossum @ 2008-07-26 18:28 UTC (permalink / raw)
To: Ingo Molnar; +Cc: Randy Dunlap, lkml, vegardno, penberg, akpm
On Sat, Jul 26, 2008 at 5:43 PM, Ingo Molnar <mingo@elte.hu> wrote:
>
> * Randy Dunlap <randy.dunlap@oracle.com> wrote:
>
>> From: Randy Dunlap <randy.dunlap@oracle.com>
>>
>> kmemcheck/shadow.c needs to include <linux/module.h> to prevent
>> the following warnings:
>>
>> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : data definition has no type or storage class
>> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : type defaults to 'int' in declaration of 'EXPORT_SYMBOL_GPL'
>> linux-next-20080724/arch/x86/mm/kmemcheck/shadow.c:64: warning : parameter names (without types) in function declaration
>
> applied to tip/kmemcheck - thanks Randy.
I am obviously also grateful for this patch. Thanks!
Vegard
--
"The animistic metaphor of the bug that maliciously sneaked in while
the programmer was not looking is intellectually dishonest as it
disguises that the error is the programmer's own creation."
-- E. W. Dijkstra, EWD1036
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2008-07-26 18:28 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-07-24 23:09 [PATCH -next] kmemcheck: include module.h to prevent warnings Randy Dunlap
2008-07-24 23:27 ` Pekka Enberg
2008-07-26 15:43 ` Ingo Molnar
2008-07-26 18:28 ` Vegard Nossum
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®