[PATCH] drivers/video/console/promcon.c: fix build error

[PATCH] drivers/video/console/promcon.c: fix build error

[Alexander Beregalov]

From: Alexander Beregalov <a.beregalov@gmail.com>

drivers/video/console/promcon.c: fix build error

drivers/video/console/promcon.c:158: error: implicit declaration of
function 'con_protect_unimap'

Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165

Signed-off-by: Alexander Beregalov <a.beregalov@gmail.com>
Cc: David Woodhouse <dwmw2@infradead.org>
Cc: Tim Bird <tim.bird@am.sony.com>
---

 include/linux/vt_kern.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/linux/vt_kern.h b/include/linux/vt_kern.h
index 8c8119f..1c78d56 100644
--- a/include/linux/vt_kern.h
+++ b/include/linux/vt_kern.h
@@ -86,6 +86,7 @@ int con_copy_unimap(struct vc_data *dst_vc, struct vc_data *src_vc);
 #define con_copy_unimap(d, s) (0)
 #define con_get_unimap(vc, ct, uct, list) (-EINVAL)
 #define con_free_unimap(vc) do { ; } while (0)
+#define con_protect_unimap(vc, rdonly) do { ; } while (0)
 
 #define vc_translate(vc, c) (c)
 #endif

Re: [PATCH] drivers/video/console/promcon.c: fix build error

[David Woodhouse]

On Sun, 2008-08-03 at 03:03 +0400, Alexander Beregalov wrote:
> From: Alexander Beregalov <a.beregalov@gmail.com>
> 
> drivers/video/console/promcon.c: fix build error
> 
> drivers/video/console/promcon.c:158: error: implicit declaration of
> function 'con_protect_unimap'
> 
> Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165

Commit a29ccf6f823a84d89e1c7aaaf221cf7282022024, surely? 

And in fact it looks like we could remove those parts of promcon.c
completely if !CONFIG_CONSOLE_TRANSLATIONS. But your patch is certainly
correct, and I've applied it to my 'random-2.6.git' tree which I've
already asked Linus to pull.

-- 
David Woodhouse                            Open Source Technology Centre
David.Woodhouse@intel.com                              Intel Corporation

Re: [PATCH] drivers/video/console/promcon.c: fix build error

[Alexander Beregalov]

2008/8/3 David Woodhouse <dwmw2@infradead.org>:
> On Sun, 2008-08-03 at 03:03 +0400, Alexander Beregalov wrote:
>> From: Alexander Beregalov <a.beregalov@gmail.com>
>>
>> drivers/video/console/promcon.c: fix build error
>>
>> drivers/video/console/promcon.c:158: error: implicit declaration of
>> function 'con_protect_unimap'
>>
>> Introduced by commit 4744b43431e8613f920c5cba88346756f53c5165
>
> Commit a29ccf6f823a84d89e1c7aaaf221cf7282022024, surely?
Yes, my mistake.
>
> And in fact it looks like we could remove those parts of promcon.c
> completely if !CONFIG_CONSOLE_TRANSLATIONS. But your patch is certainly
> correct, and I've applied it to my 'random-2.6.git' tree which I've
> already asked Linus to pull.
Thanks.