* [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static
@ 2008-04-23 9:52 Adrian Bunk
2008-04-23 11:24 ` Konrad Rzeszutek
2008-08-12 19:43 ` Konrad Rzeszutek
0 siblings, 2 replies; 5+ messages in thread
From: Adrian Bunk @ 2008-04-23 9:52 UTC (permalink / raw)
To: Konrad Rzeszutek, James Bottomley; +Cc: linux-scsi, linux-kernel
This patch makes the following needlessly global functions static:
- ibft_attr_show_initiator()
- ibft_attr_show_nic()
- ibft_attr_show_target()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
---
drivers/firmware/iscsi_ibft.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
421adc9620a633d461059da9a8a94315d8a767ea diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 8024e3b..8523811 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj)
/*
* Routines for parsing the iBFT data to be human readable.
*/
-ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
- struct ibft_attribute *attr,
- char *buf)
+static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+ char *buf)
{
struct ibft_initiator *initiator = entry->initiator;
void *ibft_loc = entry->header;
@@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
return str - buf;
}
-ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
- struct ibft_attribute *attr,
- char *buf)
+static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+ char *buf)
{
struct ibft_nic *nic = entry->nic;
void *ibft_loc = entry->header;
@@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
return str - buf;
};
-ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
- struct ibft_attribute *attr,
- char *buf)
+static ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+ char *buf)
{
struct ibft_tgt *tgt = entry->tgt;
void *ibft_loc = entry->header;
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static
2008-04-23 9:52 [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static Adrian Bunk
@ 2008-04-23 11:24 ` Konrad Rzeszutek
2008-08-12 19:43 ` Konrad Rzeszutek
1 sibling, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek @ 2008-04-23 11:24 UTC (permalink / raw)
To: Adrian Bunk; +Cc: Konrad Rzeszutek, James Bottomley, linux-scsi, linux-kernel
On Wednesday 23 April 2008 05:52:30 Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - ibft_attr_show_initiator()
> - ibft_attr_show_nic()
> - ibft_attr_show_target()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
Thanks for catching that.
Signed-off-by: Konrad Rzeszutek <ketuzsezr@darnok.org>
>
> ---
>
> drivers/firmware/iscsi_ibft.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> 421adc9620a633d461059da9a8a94315d8a767ea diff --git
> a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c index
> 8024e3b..8523811 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj)
> /*
> * Routines for parsing the iBFT data to be human readable.
> */
> -ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_initiator *initiator = entry->initiator;
> void *ibft_loc = entry->header;
> @@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject
> *entry, return str - buf;
> }
>
> -ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_nic *nic = entry->nic;
> void *ibft_loc = entry->header;
> @@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> return str - buf;
> };
>
> -ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_tgt *tgt = entry->tgt;
> void *ibft_loc = entry->header;
^ permalink raw reply [flat|nested] 5+ messages in thread
* [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static
2008-04-23 9:52 [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static Adrian Bunk
2008-04-23 11:24 ` Konrad Rzeszutek
@ 2008-08-12 19:43 ` Konrad Rzeszutek
2008-08-12 19:43 ` [PATCH] " Konrad Rzeszutek
1 sibling, 1 reply; 5+ messages in thread
From: Konrad Rzeszutek @ 2008-08-12 19:43 UTC (permalink / raw)
To: gregkh; +Cc: pjones, linux-kernel
Greg,
Please at your convience include this patch in your update to the drivers/firmware directory if it
is not too much trouble.
Thank you,
Konrad Rzeszutek
iscsi_ibft.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH] drivers/firmware/iscsi_ibft.c: make 3 functions static
2008-08-12 19:43 ` Konrad Rzeszutek
@ 2008-08-12 19:43 ` Konrad Rzeszutek
2008-08-12 20:01 ` Konrad Rzeszutek
0 siblings, 1 reply; 5+ messages in thread
From: Konrad Rzeszutek @ 2008-08-12 19:43 UTC (permalink / raw)
To: gregkh; +Cc: pjones, linux-kernel, Adrian Bunk, Konrad Rzeszutek
From: Adrian Bunk <bunk@kernel.org>
This patch makes the following needlessly global functions static:
- ibft_attr_show_initiator()
- ibft_attr_show_nic()
- ibft_attr_show_target()
Signed-off-by: Adrian Bunk <bunk@kernel.org>
Signed-off-by: Konrad Rzeszutek <ketuzsezr@darnok.org>
---
drivers/firmware/iscsi_ibft.c | 18 +++++++++---------
1 files changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
index 8024e3b..8523811 100644
--- a/drivers/firmware/iscsi_ibft.c
+++ b/drivers/firmware/iscsi_ibft.c
@@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj)
/*
* Routines for parsing the iBFT data to be human readable.
*/
-ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
- struct ibft_attribute *attr,
- char *buf)
+static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+ char *buf)
{
struct ibft_initiator *initiator = entry->initiator;
void *ibft_loc = entry->header;
@@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
return str - buf;
}
-ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
- struct ibft_attribute *attr,
- char *buf)
+static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+ char *buf)
{
struct ibft_nic *nic = entry->nic;
void *ibft_loc = entry->header;
@@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
return str - buf;
};
-ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
- struct ibft_attribute *attr,
- char *buf)
+static ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
+ struct ibft_attribute *attr,
+ char *buf)
{
struct ibft_tgt *tgt = entry->tgt;
void *ibft_loc = entry->header;
--
1.5.4.3
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] drivers/firmware/iscsi_ibft.c: make 3 functions static
2008-08-12 19:43 ` [PATCH] " Konrad Rzeszutek
@ 2008-08-12 20:01 ` Konrad Rzeszutek
0 siblings, 0 replies; 5+ messages in thread
From: Konrad Rzeszutek @ 2008-08-12 20:01 UTC (permalink / raw)
To: gregkh; +Cc: pjones, linux-kernel, Adrian Bunk
This was suppose to include this nice little intro but I haven't
mastered the git-send-email yet. Here it is:
Dear Greg,
At your convience please include this patch in your update to the
drivers/firmware directory if it is not too much trouble.
Thank you,
Konrad Rzeszutek
On Tue, Aug 12, 2008 at 03:43:59PM -0400, Konrad Rzeszutek wrote:
> From: Adrian Bunk <bunk@kernel.org>
>
> This patch makes the following needlessly global functions static:
> - ibft_attr_show_initiator()
> - ibft_attr_show_nic()
> - ibft_attr_show_target()
>
> Signed-off-by: Adrian Bunk <bunk@kernel.org>
> Signed-off-by: Konrad Rzeszutek <ketuzsezr@darnok.org>
> ---
> drivers/firmware/iscsi_ibft.c | 18 +++++++++---------
> 1 files changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/firmware/iscsi_ibft.c b/drivers/firmware/iscsi_ibft.c
> index 8024e3b..8523811 100644
> --- a/drivers/firmware/iscsi_ibft.c
> +++ b/drivers/firmware/iscsi_ibft.c
> @@ -334,9 +334,9 @@ static void ibft_release(struct kobject *kobj)
> /*
> * Routines for parsing the iBFT data to be human readable.
> */
> -ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_initiator *initiator = entry->initiator;
> void *ibft_loc = entry->header;
> @@ -376,9 +376,9 @@ ssize_t ibft_attr_show_initiator(struct ibft_kobject *entry,
> return str - buf;
> }
>
> -ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_nic *nic = entry->nic;
> void *ibft_loc = entry->header;
> @@ -440,9 +440,9 @@ ssize_t ibft_attr_show_nic(struct ibft_kobject *entry,
> return str - buf;
> };
>
> -ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> - struct ibft_attribute *attr,
> - char *buf)
> +static ssize_t ibft_attr_show_target(struct ibft_kobject *entry,
> + struct ibft_attribute *attr,
> + char *buf)
> {
> struct ibft_tgt *tgt = entry->tgt;
> void *ibft_loc = entry->header;
> --
> 1.5.4.3
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2008-08-12 20:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-04-23 9:52 [2.6 patch] drivers/firmware/iscsi_ibft.c: make 3 functions static Adrian Bunk
2008-04-23 11:24 ` Konrad Rzeszutek
2008-08-12 19:43 ` Konrad Rzeszutek
2008-08-12 19:43 ` [PATCH] " Konrad Rzeszutek
2008-08-12 20:01 ` Konrad Rzeszutek
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®