From: David Miller <davem@davemloft.net>
To: penberg@cs.helsinki.fi
Cc: vegard.nossum@gmail.com, vegardno@ifi.uio.no,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
jgarzik@pobox.com, adobriyan@gmail.com
Subject: Re: [RFC][PATCH] netconsole: avoid deadlock on printk from driver code
Date: Thu, 14 Aug 2008 15:15:02 -0700 (PDT) [thread overview]
Message-ID: <20080814.151502.251134900.davem@davemloft.net> (raw)
In-Reply-To: <Pine.LNX.4.64.0808141643200.3164@sbz-30.cs.Helsinki.FI>
From: Pekka J Enberg <penberg@cs.helsinki.fi>
Date: Thu, 14 Aug 2008 16:44:32 +0300 (EEST)
> @@ -598,6 +598,7 @@
>
> spinlock_t lock;
> spinlock_t rx_lock;
> + spinlock_t tx_lock;
>
> chip_t chipset;
> u32 rx_config;
Why create a special purpose lock when the generic networking
already is taking a lock for you to proect the TX path?
Furthermore, as I just described in another reply, netpoll
already knows that it might need to trylock() attempt on this
lock in order to avoid the very deadlocks this thread is
about.
next prev parent reply other threads:[~2008-08-14 22:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-08-13 9:53 Vegard Nossum
2008-08-13 9:59 ` Alexey Dobriyan
2008-08-13 10:21 ` Vegard Nossum
2008-08-13 10:29 ` David Miller
2008-08-13 10:44 ` Vegard Nossum
2008-08-13 10:56 ` David Miller
2008-08-13 10:37 ` David Miller
2008-08-14 13:28 ` Pekka Enberg
2008-08-14 13:44 ` Pekka J Enberg
2008-08-14 22:15 ` David Miller [this message]
2008-08-20 17:54 ` Pekka J Enberg
2008-08-20 19:56 ` Vegard Nossum
2008-08-20 20:58 ` David Miller
2008-08-14 22:13 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20080814.151502.251134900.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=adobriyan@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=penberg@cs.helsinki.fi \
--cc=vegard.nossum@gmail.com \
--cc=vegardno@ifi.uio.no \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®