* [PATCH] FTRACE_STARTUP_TEST should depend on FTRACE.
@ 2008-09-15 0:02 Steven Noonan
2008-09-15 7:17 ` Ingo Molnar
0 siblings, 1 reply; 2+ messages in thread
From: Steven Noonan @ 2008-09-15 0:02 UTC (permalink / raw)
To: linux-kernel; +Cc: mingo, Steven Noonan
Doesn't make sense to do an FTRACE startup test when FTRACE isn't
even being compiled in.
Signed-off-by: Steven Noonan <steven@uplinklabs.net>
---
kernel/trace/Kconfig | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)
diff --git a/kernel/trace/Kconfig b/kernel/trace/Kconfig
index 16e5bb5..1ee0400 100644
--- a/kernel/trace/Kconfig
+++ b/kernel/trace/Kconfig
@@ -152,6 +152,7 @@ config FTRACE_SELFTEST
config FTRACE_STARTUP_TEST
bool "Perform a startup test on ftrace"
depends on TRACING
+ depends on FTRACE
depends on DEBUG_KERNEL
select FTRACE_SELFTEST
help
--
1.6.0.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] FTRACE_STARTUP_TEST should depend on FTRACE.
2008-09-15 0:02 [PATCH] FTRACE_STARTUP_TEST should depend on FTRACE Steven Noonan
@ 2008-09-15 7:17 ` Ingo Molnar
0 siblings, 0 replies; 2+ messages in thread
From: Ingo Molnar @ 2008-09-15 7:17 UTC (permalink / raw)
To: Steven Noonan; +Cc: linux-kernel, Steven Rostedt
* Steven Noonan <steven@uplinklabs.net> wrote:
> Doesn't make sense to do an FTRACE startup test when FTRACE isn't even
> being compiled in.
hm, not sure - there is a bit of a dual personality here: 'ftrace' also
means the 'function tracer', which is one of the tracers implemented in
kernel/trace/*. The correct dependency is on CONFIG_TRACING - and
CONFIG_FTRACE_STARTUP_TEST already depends on that.
Ingo
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2008-09-15 7:17 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-15 0:02 [PATCH] FTRACE_STARTUP_TEST should depend on FTRACE Steven Noonan
2008-09-15 7:17 ` Ingo Molnar
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®