mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH -mm] eeepc: depends on RFKILL
@ 2008-09-15 19:52 Randy Dunlap
  2008-09-16  7:05 ` Corentin Chary
  0 siblings, 1 reply; 2+ messages in thread
From: Randy Dunlap @ 2008-09-15 19:52 UTC (permalink / raw)
  To: lkml; +Cc: akpm, Corentin Chary, acpi4asus-user

From: Randy Dunlap <randy.dunlap@oracle.com>

EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL.
Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.

eeepc-laptop.c:(.text+0xd5a7b): undefined reference to `rfkill_allocate'
eeepc-laptop.c:(.text+0xd5b04): undefined reference to `rfkill_register'
eeepc-laptop.c:(.text+0xd5b48): undefined reference to `rfkill_allocate'
eeepc-laptop.c:(.text+0xd5bd4): undefined reference to `rfkill_register'
eeepc-laptop.c:(.text+0xd5ece): undefined reference to `rfkill_unregister'
eeepc-laptop.c:(.text+0xd5ef6): undefined reference to `rfkill_unregister'
make[1]: *** [.tmp_vmlinux1] Error 1

Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
cc: Corentin Chary <corentincj@iksaif.net>
---
 drivers/misc/Kconfig |    1 +
 1 file changed, 1 insertion(+)

--- linux-2.6.27-rc5-mm1.orig/drivers/misc/Kconfig
+++ linux-2.6.27-rc5-mm1/drivers/misc/Kconfig
@@ -410,6 +410,7 @@ config EEEPC_LAPTOP
 	depends on BACKLIGHT_CLASS_DEVICE
 	depends on HWMON
 	depends on EXPERIMENTAL
+	depends on RFKILL
 	---help---
 	  This driver supports the Fn-Fx keys on Eee PC laptops.
 	  It also adds the ability to switch camera/wlan on/off.

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH -mm] eeepc: depends on RFKILL
  2008-09-15 19:52 [PATCH -mm] eeepc: depends on RFKILL Randy Dunlap
@ 2008-09-16  7:05 ` Corentin Chary
  0 siblings, 0 replies; 2+ messages in thread
From: Corentin Chary @ 2008-09-16  7:05 UTC (permalink / raw)
  To: Randy Dunlap; +Cc: lkml, akpm, acpi4asus-user

Yep, it should depends on RFKILL, and I should start porting
asus-laptop to rfkill.
Thanks for this patch.

On Mon, Sep 15, 2008 at 9:52 PM, Randy Dunlap <randy.dunlap@oracle.com> wrote:
> From: Randy Dunlap <randy.dunlap@oracle.com>
>
> EEEPC_LAPTOP uses RFKILL, so the former should depend on RFKILL.
> Build errors happen when EEEPC_LAPTOP=y and RFKILL=m.
>
> eeepc-laptop.c:(.text+0xd5a7b): undefined reference to `rfkill_allocate'
> eeepc-laptop.c:(.text+0xd5b04): undefined reference to `rfkill_register'
> eeepc-laptop.c:(.text+0xd5b48): undefined reference to `rfkill_allocate'
> eeepc-laptop.c:(.text+0xd5bd4): undefined reference to `rfkill_register'
> eeepc-laptop.c:(.text+0xd5ece): undefined reference to `rfkill_unregister'
> eeepc-laptop.c:(.text+0xd5ef6): undefined reference to `rfkill_unregister'
> make[1]: *** [.tmp_vmlinux1] Error 1
>
> Signed-off-by: Randy Dunlap <randy.dunlap@oracle.com>
> cc: Corentin Chary <corentincj@iksaif.net>
> ---
>  drivers/misc/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
>
> --- linux-2.6.27-rc5-mm1.orig/drivers/misc/Kconfig
> +++ linux-2.6.27-rc5-mm1/drivers/misc/Kconfig
> @@ -410,6 +410,7 @@ config EEEPC_LAPTOP
>        depends on BACKLIGHT_CLASS_DEVICE
>        depends on HWMON
>        depends on EXPERIMENTAL
> +       depends on RFKILL
>        ---help---
>          This driver supports the Fn-Fx keys on Eee PC laptops.
>          It also adds the ability to switch camera/wlan on/off.
>

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2008-09-16  7:06 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2008-09-15 19:52 [PATCH -mm] eeepc: depends on RFKILL Randy Dunlap
2008-09-16  7:05 ` Corentin Chary

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®