mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Komuro <komurojun-mbn@nifty.com>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: linux-kernel@vger.kernel.org
Subject: RE: [PATCH 03/19] pcmcia: Whine harder about use of EXCLUSIVE
Date: Mon, 6 Oct 2008 21:18:30 +0900	[thread overview]
Message-ID: <20081006211830.4976f166.komurojun-mbn@nifty.com> (raw)
In-Reply-To: <20080922231227.2625dd09@lxorguk.ukuu.org.uk>



duplicate warning message in pcmcia_resource.c ....


>   /* Make sure the fact the request type was overridden is passed back */
>    if (type == IRQF_SHARED && !(req->Attributes & IRQ_TYPE_DYNAMIC_SHARING)) {
>        req->Attributes |= IRQ_TYPE_DYNAMIC_SHARING;
>        printk(KERN_WARNING "pcmcia: request for exclusive IRQ could not be fulfilled.\n");
>        printk(KERN_WARNING "pcmcia: the driver needs updating to supported shared IRQ lines\n");
>     }



>diff --git a/drivers/pcmcia/pcmcia_resource.c b/drivers/pcmcia/pcmcia_resource.c
>index 4884a18..8f1c3d4 100644
>--- a/drivers/pcmcia/pcmcia_resource.c
>+++ b/drivers/pcmcia/pcmcia_resource.c
>@@ -738,8 +738,9 @@ int pcmcia_request_irq(struct pcmcia_device *p_dev, irq_req_t *req)
> 	type = 0;
> 	if (s->functions > 1)		/* All of this ought to be handled higher up */
> 		type = IRQF_SHARED;
>-	if (req->Attributes & IRQ_TYPE_DYNAMIC_SHARING)
>+	else if (req->Attributes & IRQ_TYPE_DYNAMIC_SHARING)
> 		type = IRQF_SHARED;
>+	else printk(KERN_WARNING "pcmcia: Driver needs updating to support IRQ sharing.\n");
> 
> #ifdef CONFIG_PCMCIA_PROBE
 

Best Regards
Komuro

  parent reply	other threads:[~2008-10-06 12:23 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-22 14:58 [PATCH] pcmcia: Fix broken abuse of dev->driver_data Alan Cox
2008-09-22 21:56 ` Dominik Brodowski
2008-09-22 22:12   ` Alan Cox
2008-09-22 22:26     ` Dominik Brodowski
2008-09-22 23:15       ` Alan Cox
2008-09-23  1:31         ` Komuro
2008-09-26 13:29         ` [PATCH git latest] drivers/net: fixing a datarace related to update_stats() Komuro
2008-09-26 16:06           ` Tammy
2008-09-26 17:31           ` Lin Tan
2008-11-01  2:07       ` [BUG REPORT!!!] [PATCH 19/49] pcmcia: remove remaining in-kernel pcmcia_get_configuration_info() users Komuro
2008-11-02  8:46         ` Komuro
2008-11-02  9:17           ` Dominik Brodowski
2008-11-02 10:33             ` Komuro
2008-11-02 12:04               ` Dominik Brodowski
2008-10-06 12:18     ` Komuro [this message]
2008-10-05 16:34 [PATCH 00/19] Alan's Miscellaneous Tree Alan Cox
2008-10-05 16:35 ` [PATCH 03/19] pcmcia: Whine harder about use of EXCLUSIVE Alan Cox
2008-10-17 21:17   ` Dominik Brodowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20081006211830.4976f166.komurojun-mbn@nifty.com \
    --to=komurojun-mbn@nifty.com \
    --cc=alan@lxorguk.ukuu.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®