From: Alan Cox <alan@lxorguk.ukuu.org.uk>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-kernel@vger.kernel.org, mingo@elte.hu, rml@tech9.net,
Alasdair G Kergon <agk@redhat.com>, Milan Broz <mbroz@redhat.com>
Subject: Re: Active waiting with yield()
Date: Fri, 14 Nov 2008 21:21:02 +0000 [thread overview]
Message-ID: <20081114212102.2313a8a3@lxorguk.ukuu.org.uk> (raw)
In-Reply-To: <Pine.LNX.4.64.0811141412290.12992@hs20-bc2-1.build.redhat.com>
> If I have a race condition that gets triggered just for one user in the
> world when repeatedly loading & unloading a driver for an hour, and I use
> yield() to solve it, what's wrong with it? A wait queue increases cache
> footprint for every user. (even if I use preallocated hashed wait queue,
> it still eats a cacheline to access it and find out that it's empty)
Reread what I wrote.
You don't need to use a hashed queue, you don't need to even reference
the queue in the normal case. You cost is one variable, which you can
probably sensibly locate, and a predicted jump.
For that you get proper sleeping behaviour, CPU used by other tasks or
guests and you don't hang on hard real time tasks.
prev parent reply other threads:[~2008-11-14 21:21 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 18:59 Mikulas Patocka
2008-11-14 19:06 ` Alan Cox
2008-11-14 19:34 ` Mikulas Patocka
2008-11-14 20:57 ` Peter Zijlstra
2008-11-14 21:41 ` Mikulas Patocka
2008-11-15 22:55 ` Peter Zijlstra
2008-11-17 17:39 ` Mikulas Patocka
2008-11-17 18:01 ` Alan Cox
2008-11-18 14:34 ` Mikulas Patocka
2008-11-18 14:40 ` Alan Cox
2008-11-18 17:11 ` Mikulas Patocka
2008-11-18 21:26 ` Alan Cox
2008-11-20 9:18 ` Mikulas Patocka
2008-11-19 16:14 ` Peter Zijlstra
2008-11-18 14:49 ` Arjan van de Ven
2008-11-18 17:14 ` Mikulas Patocka
2008-11-14 21:21 ` Alan Cox [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081114212102.2313a8a3@lxorguk.ukuu.org.uk \
--to=alan@lxorguk.ukuu.org.uk \
--cc=agk@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mingo@elte.hu \
--cc=mpatocka@redhat.com \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®