From: Arjan van de Ven <arjan@infradead.org>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org, mingo@elte.hu, rml@tech9.net,
Alasdair G Kergon <agk@redhat.com>, Milan Broz <mbroz@redhat.com>
Subject: Re: Active waiting with yield()
Date: Tue, 18 Nov 2008 06:49:43 -0800 [thread overview]
Message-ID: <20081118064943.332516f7@infradead.org> (raw)
In-Reply-To: <Pine.LNX.4.64.0811180921450.12274@hs20-bc2-1.build.redhat.com>
On Tue, 18 Nov 2008 09:34:16 -0500 (EST)
> So what are the reasons why you (and others) are against active
> waiting? All you are saying is that my reasons are wrong, but you
> haven't single example when active waiting causes trouble. If there
> is a workload when waiting 1ms-to-10ms with mdelay(1) on driver
> unload would cause discomfort to the user, describe it.
>
mdelay()
* costs you quite a bit of power
* will cause your cpu to go to full speed
* makes it more likely that your fan goes on
* takes away CPU time from others who do want to run
- including the guy you are waiting for!
* if you do it with interrupts off you can even cause time skew
* adds 10 milliseconds of latency to the entire system, which is very
user noticable in a desktop environment (the threshold for that is
like 1 or 2 milliseconds total)
now there are some cases, mostly during error recovery or driver init
slowpaths where mdelay() can be justified, but "I'm too lazy to use a
waitqueue or other sleeping construct" is not one of them.
--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org
next prev parent reply other threads:[~2008-11-18 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-14 18:59 Mikulas Patocka
2008-11-14 19:06 ` Alan Cox
2008-11-14 19:34 ` Mikulas Patocka
2008-11-14 20:57 ` Peter Zijlstra
2008-11-14 21:41 ` Mikulas Patocka
2008-11-15 22:55 ` Peter Zijlstra
2008-11-17 17:39 ` Mikulas Patocka
2008-11-17 18:01 ` Alan Cox
2008-11-18 14:34 ` Mikulas Patocka
2008-11-18 14:40 ` Alan Cox
2008-11-18 17:11 ` Mikulas Patocka
2008-11-18 21:26 ` Alan Cox
2008-11-20 9:18 ` Mikulas Patocka
2008-11-19 16:14 ` Peter Zijlstra
2008-11-18 14:49 ` Arjan van de Ven [this message]
2008-11-18 17:14 ` Mikulas Patocka
2008-11-14 21:21 ` Alan Cox
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081118064943.332516f7@infradead.org \
--to=arjan@infradead.org \
--cc=agk@redhat.com \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=mbroz@redhat.com \
--cc=mingo@elte.hu \
--cc=mpatocka@redhat.com \
--cc=peterz@infradead.org \
--cc=rml@tech9.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®