From: Nick Andrew <nick@nick-andrew.net>
To: Jiri Kosina <jkosina@suse.cz>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] trivial: printk: fix indentation of new_text_line declaration
Date: Fri, 5 Dec 2008 00:17:52 +1100 [thread overview]
Message-ID: <20081204131752.GA16905@mail.local.tull.net> (raw)
In-Reply-To: <alpine.LNX.1.10.0812041242260.5809@jikos.suse.cz>
On Thu, Dec 04, 2008 at 12:44:34PM +0100, Jiri Kosina wrote:
> I have just come across bogus indentation of new_text_line declaration. I
> have applied the patch below to trivial tree. If the indentation had some
> specific non-obvious purpose and was done intentionally this way, please
> let me know :)
That's cool. Ingo tweaked my patch and moved the static declaration
outside the function and mistakenly left the indent in place.
I'm actually not too happy about new_text_line being a static; I may
well submit a patch to fix that. But in the meantime, fixing the indent
is fine.
> From: Jiri Kosina <jkosina@suse.cz>
> Subject: trivial: printk: fix indentation of new_text_line declaration
>
> Remove bogus indentation of new_text_line declaration introduced in
> commit ac60ad741.
>
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>
Acked-by: Nick Andrew <nick@nick-andrew.net>
Nick.
prev parent reply other threads:[~2008-12-04 13:18 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-04 11:44 Jiri Kosina
2008-12-04 13:17 ` Nick Andrew [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081204131752.GA16905@mail.local.tull.net \
--to=nick@nick-andrew.net \
--cc=jkosina@suse.cz \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®