[PATCH] trivial: printk: fix indentation of new_text_line declaration

[PATCH] trivial: printk: fix indentation of new_text_line declaration

[Jiri Kosina]

Hi Nick,

I have just come across bogus indentation of new_text_line declaration. I 
have applied the patch below to trivial tree. If the indentation had some 
specific non-obvious purpose and was done intentionally this way, please 
let me know :)



From: Jiri Kosina <jkosina@suse.cz>
Subject: trivial: printk: fix indentation of new_text_line declaration

Remove bogus indentation of new_text_line declaration introduced in
commit ac60ad741.

Signed-off-by: Jiri Kosina <jkosina@suse.cz>
---
 kernel/printk.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/kernel/printk.c b/kernel/printk.c
index f492f15..fb17944 100644
--- a/kernel/printk.c
+++ b/kernel/printk.c
@@ -619,7 +619,7 @@ static int acquire_console_semaphore_for_printk(unsigned int cpu)
 static const char recursion_bug_msg [] =
 		KERN_CRIT "BUG: recent printk recursion!\n";
 static int recursion_bug;
-	static int new_text_line = 1;
+static int new_text_line = 1;
 static char printk_buf[1024];
 
 asmlinkage int vprintk(const char *fmt, va_list args)
-- 
1.5.6

Re: [PATCH] trivial: printk: fix indentation of new_text_line declaration

[Nick Andrew]

On Thu, Dec 04, 2008 at 12:44:34PM +0100, Jiri Kosina wrote:
> I have just come across bogus indentation of new_text_line declaration. I 
> have applied the patch below to trivial tree. If the indentation had some 
> specific non-obvious purpose and was done intentionally this way, please 
> let me know :)

That's cool. Ingo tweaked my patch and moved the static declaration
outside the function and mistakenly left the indent in place.

I'm actually not too happy about new_text_line being a static; I may
well submit a patch to fix that. But in the meantime, fixing the indent
is fine.

> From: Jiri Kosina <jkosina@suse.cz>
> Subject: trivial: printk: fix indentation of new_text_line declaration
> 
> Remove bogus indentation of new_text_line declaration introduced in
> commit ac60ad741.
> 
> Signed-off-by: Jiri Kosina <jkosina@suse.cz>

Acked-by: Nick Andrew <nick@nick-andrew.net>

Nick.