From: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
To: Linux Kernel <linux-kernel@vger.kernel.org>,
Suresh B Siddha <suresh.b.siddha@intel.com>,
Venkatesh Pallipadi <venkatesh.pallipadi@intel.com>,
Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Ingo Molnar <mingo@elte.hu>, Dipankar Sarma <dipankar@in.ibm.com>,
Balbir Singh <balbir@linux.vnet.ibm.com>,
Vatsa <vatsa@linux.vnet.ibm.com>,
Gautham R Shenoy <ego@in.ibm.com>,
Andi Kleen <andi@firstfloor.org>,
David Collier-Brown <davecb@sun.com>,
Tim Connors <tconnors@astro.swin.edu.au>,
Max Krasnyansky <maxk@qualcomm.com>,
Gregory Haskins <gregory.haskins@gmail.com>,
Pavel Machek <pavel@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
Subject: [PATCH v7 7/8] sched: add SD_BALANCE_NEWIDLE at MC and CPU level for sched_mc>0
Date: Thu, 18 Dec 2008 23:26:47 +0530 [thread overview]
Message-ID: <20081218175647.29812.34915.stgit@drishya.in.ibm.com> (raw)
In-Reply-To: <20081218175313.29812.4781.stgit@drishya.in.ibm.com>
Add SD_BALANCE_NEWIDLE flag at MC level and CPU level
if sched_mc is set. This helps power savings and
will not affect performance when sched_mc=0
Ingo and Mike Galbraith have optimised the SD flags by
removing SD_BALANCE_NEWIDLE at MC and CPU level. This
helps performance but hurts power savings since this
slows down task consolidation by reducing the number
of times load_balance is run.
sched: fine-tune SD_MC_INIT
commit 14800984706bf6936bbec5187f736e928be5c218
Author: Mike Galbraith <efault@gmx.de>
Date: Fri Nov 7 15:26:50 2008 +0100
sched: re-tune balancing -- revert
commit 9fcd18c9e63e325dbd2b4c726623f760788d5aa8
Author: Ingo Molnar <mingo@elte.hu>
Date: Wed Nov 5 16:52:08 2008 +0100
This patch selectively enables SD_BALANCE_NEWIDLE flag
only when sched_mc is set to 1 or 2. This helps power savings
by task consolidation and also does not hurt performance at
sched_mc=0 where all power saving optimisations are turned off.
Signed-off-by: Vaidyanathan Srinivasan <svaidy@linux.vnet.ibm.com>
---
include/linux/sched.h | 13 +++++++++++++
include/linux/topology.h | 6 ++++--
2 files changed, 17 insertions(+), 2 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 5fe906b..07348ff 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -793,6 +793,19 @@ static inline int sd_balance_for_package_power(void)
return 0;
}
+/*
+ * Optimise SD flags for power savings:
+ * SD_BALANCE_NEWIDLE helps agressive task consolidation and power savings.
+ * Keep default SD flags if sched_{smt,mc}_power_saving=0
+ */
+
+static inline int sd_power_saving_flags(void)
+{
+ if (sched_mc_power_savings | sched_smt_power_savings)
+ return SD_BALANCE_NEWIDLE;
+
+ return 0;
+}
struct sched_group {
struct sched_group *next; /* Must be a circular list */
diff --git a/include/linux/topology.h b/include/linux/topology.h
index 7f10439..1628b43 100644
--- a/include/linux/topology.h
+++ b/include/linux/topology.h
@@ -125,7 +125,8 @@ void arch_update_cpu_topology(void);
| SD_WAKE_AFFINE \
| SD_WAKE_BALANCE \
| SD_SHARE_PKG_RESOURCES\
- | sd_balance_for_mc_power(),\
+ | sd_balance_for_mc_power()\
+ | sd_power_saving_flags(),\
.last_balance = jiffies, \
.balance_interval = 1, \
}
@@ -150,7 +151,8 @@ void arch_update_cpu_topology(void);
| SD_BALANCE_FORK \
| SD_WAKE_AFFINE \
| SD_WAKE_BALANCE \
- | sd_balance_for_package_power(),\
+ | sd_balance_for_package_power()\
+ | sd_power_saving_flags(),\
.last_balance = jiffies, \
.balance_interval = 1, \
}
next prev parent reply other threads:[~2008-12-18 17:55 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-12-18 17:55 [PATCH v7 0/8] Tunable sched_mc_power_savings=n Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 1/8] sched: convert BALANCE_FOR_xx_POWER to inline functions Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 2/8] sched: Framework for sched_mc/smt_power_savings=N Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 3/8] sched: favour lower logical cpu number for sched_mc balance Vaidyanathan Srinivasan
2008-12-18 17:56 ` [PATCH v7 4/8] sched: nominate preferred wakeup cpu Vaidyanathan Srinivasan
2008-12-18 18:12 ` Balbir Singh
2008-12-19 21:55 ` Andrew Morton
2008-12-19 22:19 ` Andrew Morton
2008-12-19 22:27 ` Ingo Molnar
2008-12-19 22:31 ` Ingo Molnar
2008-12-19 22:38 ` Andrew Morton
2008-12-19 22:54 ` Ingo Molnar
2008-12-20 4:36 ` Vaidyanathan Srinivasan
2008-12-20 4:44 ` Andrew Morton
2008-12-20 7:54 ` Ingo Molnar
2008-12-20 10:02 ` Vaidyanathan Srinivasan
2008-12-20 10:36 ` Vaidyanathan Srinivasan
2008-12-20 10:56 ` Vaidyanathan Srinivasan
2008-12-21 8:46 ` Ingo Molnar
2008-12-18 17:56 ` [PATCH v7 5/8] sched: bias task wakeups to preferred semi-idle packages Vaidyanathan Srinivasan
2008-12-18 18:11 ` Balbir Singh
2008-12-18 17:56 ` [PATCH v7 6/8] sched: activate active load balancing in new idle cpus Vaidyanathan Srinivasan
2008-12-18 17:56 ` Vaidyanathan Srinivasan [this message]
2008-12-18 17:56 ` [PATCH v7 8/8] sched: idle_balance() does not call load_balance_newidle() Vaidyanathan Srinivasan
2008-12-18 18:12 ` Balbir Singh
2008-12-18 20:17 ` Ingo Molnar
2008-12-18 20:19 ` [PATCH v7 0/8] Tunable sched_mc_power_savings=n Ingo Molnar
2008-12-18 20:31 ` Ingo Molnar
2008-12-19 8:29 ` Vaidyanathan Srinivasan
2008-12-19 8:24 ` Vaidyanathan Srinivasan
2008-12-19 13:34 ` Vaidyanathan Srinivasan
2008-12-29 23:43 ` MinChan Kim
2008-12-30 2:48 ` Balbir Singh
2008-12-30 6:21 ` Ingo Molnar
2008-12-30 6:44 ` Balbir Singh
2008-12-30 7:20 ` Ingo Molnar
2008-12-30 18:07 ` Vaidyanathan Srinivasan
2009-01-02 7:26 ` Vaidyanathan Srinivasan
2009-01-02 22:16 ` Ingo Molnar
2009-01-03 7:29 ` Mike Galbraith
2009-01-03 10:16 ` Vaidyanathan Srinivasan
2009-01-03 11:22 ` Mike Galbraith
2009-01-04 15:00 ` Mike Galbraith
2009-01-04 18:19 ` Vaidyanathan Srinivasan
2009-01-04 19:52 ` Mike Galbraith
2009-01-05 3:20 ` Vaidyanathan Srinivasan
2009-01-05 4:40 ` Mike Galbraith
2009-01-05 6:36 ` Mike Galbraith
2009-01-05 15:19 ` Mike Galbraith
2009-01-06 9:31 ` Mike Galbraith
2009-01-06 15:07 ` Vaidyanathan Srinivasan
2009-01-06 17:48 ` Mike Galbraith
2009-01-06 18:45 ` Balbir Singh
2009-01-07 8:59 ` Mike Galbraith
2009-01-07 11:26 ` Vaidyanathan Srinivasan
2009-01-07 14:36 ` Mike Galbraith
2009-01-07 15:35 ` Vaidyanathan Srinivasan
2009-01-08 8:06 ` Mike Galbraith
2009-01-08 17:46 ` Vaidyanathan Srinivasan
2009-01-09 6:00 ` Mike Galbraith
2009-01-06 14:54 ` Vaidyanathan Srinivasan
2008-12-30 17:31 ` Vaidyanathan Srinivasan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20081218175647.29812.34915.stgit@drishya.in.ibm.com \
--to=svaidy@linux.vnet.ibm.com \
--cc=a.p.zijlstra@chello.nl \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=balbir@linux.vnet.ibm.com \
--cc=davecb@sun.com \
--cc=dipankar@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=gregory.haskins@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maxk@qualcomm.com \
--cc=mingo@elte.hu \
--cc=pavel@suse.cz \
--cc=suresh.b.siddha@intel.com \
--cc=tconnors@astro.swin.edu.au \
--cc=vatsa@linux.vnet.ibm.com \
--cc=venkatesh.pallipadi@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®