2.6.28-git3 and i915 Kconfig new dependency on framebuffer

2.6.28-git3 and i915 Kconfig new dependency on framebuffer

[Alessandro Suardi]

make oldconfig from -git2 to -git3 doesn't build i915.ko unless
 one has CONFIG_FB enabled; this causes /dev/dri/card0 to
 be missing, and DRI disabled from within X.

Do I now (2.6.28-git3+) need CONFIG_FB to enable i915 DRM ?

Thanks,

--alessandro

 "Sun keeps rising in the west / I keep on waking fully confused"

   (The Replacements, "Within Your Reach")

Re: 2.6.28-git3 and i915 Kconfig new dependency on framebuffer

[Eric Anholt]

[-- Attachment #1: Type: text/plain, Size: 859 bytes --]

On Wed, 2008-12-31 at 19:55 +0100, Alessandro Suardi wrote:
> make oldconfig from -git2 to -git3 doesn't build i915.ko unless
>  one has CONFIG_FB enabled; this causes /dev/dri/card0 to
>  be missing, and DRI disabled from within X.
> 
> Do I now (2.6.28-git3+) need CONFIG_FB to enable i915 DRM ?

Yes, the i915 driver now relies on fb code, though the new features are
runtime optional.  I may have noviced the Kconfig bits -- my intention
was "If you select I915, you also get all the CONFIG_FB-related bits
necessary".

config DRM_I915
        select FB_CFB_FILLRECT
        select FB_CFB_COPYAREA
        select FB_CFB_IMAGEBLIT
        depends on FB
        tristate "i915 driver"

I'm guessing that that "depends on FB" wants to be "select FB".

-- 
Eric Anholt
eric@anholt.net                         eric.anholt@intel.com



[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 197 bytes --]

Re: 2.6.28-git3 and i915 Kconfig new dependency on framebuffer

[Sam Ravnborg]

On Fri, Jan 02, 2009 at 02:50:08PM -0800, Eric Anholt wrote:
> On Wed, 2008-12-31 at 19:55 +0100, Alessandro Suardi wrote:
> > make oldconfig from -git2 to -git3 doesn't build i915.ko unless
> >  one has CONFIG_FB enabled; this causes /dev/dri/card0 to
> >  be missing, and DRI disabled from within X.
> > 
> > Do I now (2.6.28-git3+) need CONFIG_FB to enable i915 DRM ?
> 
> Yes, the i915 driver now relies on fb code, though the new features are
> runtime optional.  I may have noviced the Kconfig bits -- my intention
> was "If you select I915, you also get all the CONFIG_FB-related bits
> necessary".
> 
> config DRM_I915
>         select FB_CFB_FILLRECT
>         select FB_CFB_COPYAREA
>         select FB_CFB_IMAGEBLIT
>         depends on FB
>         tristate "i915 driver"
> 
> I'm guessing that that "depends on FB" wants to be "select FB".

No - that would not fly...
You somehow need to educate the people that want to enable DRM_I915 that
they cannot do so before they enable framebuffer support.

When you consider using select on a symbol that has a prompt
you have a good sign that you do something wrong.

	Sam