[PATCH 1/2] CRED: Missing put_cred() in prepare_kernel_cred()

[PATCH 1/2] CRED: Missing put_cred() in prepare_kernel_cred()

[David Howells]

Missing put_cred() in the error handling path of prepare_kernel_cred().

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
---

 kernel/cred.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index 480a61a..400e608 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -530,6 +530,7 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon)
 
 error:
 	put_cred(new);
+	put_cred(old);
 	return NULL;
 }
 EXPORT_SYMBOL(prepare_kernel_cred);

[PATCH 2/2] CRED: Must initialise the new creds in prepare_kernel_cred()

[David Howells]

The newly allocated creds in prepare_kernel_cred() must be initialised before
get_uid() and get_group_info() can access them.  They should be copied from
the old credentials.

Reported-by: Steve Dickson <steved@redhat.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
---

 kernel/cred.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/kernel/cred.c b/kernel/cred.c
index 400e608..3a03918 100644
--- a/kernel/cred.c
+++ b/kernel/cred.c
@@ -507,6 +507,7 @@ struct cred *prepare_kernel_cred(struct task_struct *daemon)
 	else
 		old = get_cred(&init_cred);
 
+	*new = *old;
 	get_uid(new->user);
 	get_group_info(new->group_info);