mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arjan van de Ven <arjan@infradead.org>
To: tom.leiming@gmail.com
Cc: kay.sievers@vrfy.org, greg@kroah.com,
	linux-kernel@vger.kernel.org, Ming Lei <tom.leiming@gmail.com>
Subject: Re: [PATCH] driver core: remove polling for driver_probe_done
Date: Thu, 29 Jan 2009 07:29:38 -0800	[thread overview]
Message-ID: <20090129072938.2761a6ed@infradead.org> (raw)
In-Reply-To: <1233242110-5422-1-git-send-email-tom.leiming@gmail.com>

> @@ -396,9 +396,9 @@ void __init prepare_namespace(void)
>  	if ((ROOT_DEV == 0) && root_wait) {
>  		printk(KERN_INFO "Waiting for root device %s...\n",
>  			saved_root_name);
> -		while (driver_probe_done() != 0 ||
> -			(ROOT_DEV = name_to_dev_t(saved_root_name))
> == 0)
> -			msleep(100);
> +		ROOT_DEV = name_to_dev_t(saved_root_name);
> +		if (ROOT_DEV)
> +			driver_probe_wait_done();
>  	}
>  

Hi,

another comment:

this is not equivalent

you turned "wait until all probing is done OR until the device exists"
into "wait until all probing is done"... which might be several seconds
longer!

  parent reply	other threads:[~2009-01-29 15:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-01-29 15:15 tom.leiming
2009-01-29 15:25 ` Arjan van de Ven
2009-01-29 15:35   ` Ming Lei
2009-01-29 15:29 ` Arjan van de Ven [this message]
2009-01-29 15:46   ` Ming Lei

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090129072938.2761a6ed@infradead.org \
    --to=arjan@infradead.org \
    --cc=greg@kroah.com \
    --cc=kay.sievers@vrfy.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=tom.leiming@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®