Re: [PATCH] driver core: remove polling for driver_probe_done

[Ming Lei <tom.leiming@gmail.com>]

2009/1/29 Arjan van de Ven <arjan@infradead.org>:
> On Thu, 29 Jan 2009 23:15:10 +0800
> tom.leiming@gmail.com wrote:
>
>> From: Ming Lei <tom.leiming@gmail.com>
>>
>> This patch renames driver_probe_done to driver_probe_wait_done,
>> and make it wait on condition variable of probe done to remove
>> polling for it in fs initialization.
>>
>
> I do not see where you add the wake_up() for waking up the wait queue...
> .... are you sure this is going to work ?

really_probe always wake up the queue of probe_waitqueue,
but no one pend on it. This patch adds the waitting on the queue.

static int really_probe(struct device *dev, struct device_driver *drv)
{
...
done:
        atomic_dec(&probe_count);
        wake_up(&probe_waitqueue);
        return ret;
｝

>
> --
> Arjan van de Ven        Intel Open Source Technology Centre
> For development, discussion and tips for power savings,
> visit http://www.lesswatts.org
>



-- 
Lei Ming