Re: [PATCH] driver core: remove polling for driver_probe_done

[Ming Lei <tom.leiming@gmail.com>]

2009/1/29 Arjan van de Ven <arjan@infradead.org>:
>> @@ -396,9 +396,9 @@ void __init prepare_namespace(void)
>>       if ((ROOT_DEV == 0) && root_wait) {
>>               printk(KERN_INFO "Waiting for root device %s...\n",
>>                       saved_root_name);
>> -             while (driver_probe_done() != 0 ||
>> -                     (ROOT_DEV = name_to_dev_t(saved_root_name))
>> == 0)
>> -                     msleep(100);
>> +             ROOT_DEV = name_to_dev_t(saved_root_name);
>> +             if (ROOT_DEV)
>> +                     driver_probe_wait_done();
>>       }
>>
>
> Hi,
>
> another comment:
>
> this is not equivalent
>
> you turned "wait until all probing is done OR until the device exists"
> into "wait until all probing is done"... which might be several seconds
> longer!

Yes, you are right. I will consider how to fix the problem.
Thanks.

>



-- 
Lei Ming