* Re: [tip:core/header-fixes] make most exported headers use strict integer types
[not found] <tip-57b4b9d7b56d283b6619a893341be16d1a0467a6@kernel.org>
@ 2009-02-26 8:47 ` Takashi Iwai
2009-02-26 8:57 ` [PATCH] fix duplicate include in emu10k1.h Arnd Bergmann
0 siblings, 1 reply; 3+ messages in thread
From: Takashi Iwai @ 2009-02-26 8:47 UTC (permalink / raw)
To: hpa, mingo, dwmw2, acme, airlied, perex, yoshfuji, mchehab, arnd,
tglx, hpa, linux-kernel
At Thu, 26 Feb 2009 01:31:04 GMT,
Arnd Bergmann wrote:
>
> diff --git a/include/sound/emu10k1.h b/include/sound/emu10k1.h
> index 10ee28e..c380056 100644
> --- a/include/sound/emu10k1.h
> +++ b/include/sound/emu10k1.h
> @@ -1,6 +1,8 @@
> #ifndef __SOUND_EMU10K1_H
> #define __SOUND_EMU10K1_H
>
> +#include <linux/types.h>
> +
> /*
> * Copyright (c) by Jaroslav Kysela <perex@perex.cz>,
> * Creative Labs, Inc.
> @@ -34,6 +36,8 @@
> #include <sound/timer.h>
> #include <linux/interrupt.h>
> #include <linux/mutex.h>
> +#include <linux/types.h>
> +
Isn't the second inclusion superfluous?
thanks,
Takashi
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] fix duplicate include in emu10k1.h
2009-02-26 8:47 ` [tip:core/header-fixes] make most exported headers use strict integer types Takashi Iwai
@ 2009-02-26 8:57 ` Arnd Bergmann
2009-02-26 9:03 ` Takashi Iwai
0 siblings, 1 reply; 3+ messages in thread
From: Arnd Bergmann @ 2009-02-26 8:57 UTC (permalink / raw)
To: Takashi Iwai
Cc: hpa, mingo, dwmw2, acme, airlied, perex, yoshfuji, mchehab, arnd,
tglx, hpa, linux-kernel
The earlier patch 'make most exported headers use strict integer types'
accidentally includes <types.h> both from the common and from the
kernel-only parts.
Signed-off-by: Arnd Bergmann <arnd@arndb.de>
---
On Thursday 26 February 2009, you wrote:
> > @@ -34,6 +36,8 @@
> > #include <sound/timer.h>
> > #include <linux/interrupt.h>
> > #include <linux/mutex.h>
> > +#include <linux/types.h>
> > +
>
> Isn't the second inclusion superfluous?
>
Yes, I must have introduced the second one first, but in the
wrong section (kernel only), and then didn't notice it when
introducing it again to fix headers_check.
--- a/include/sound/emu10k1.h
+++ b/include/sound/emu10k1.h
@@ -36,7 +36,6 @@
#include <sound/timer.h>
#include <linux/interrupt.h>
#include <linux/mutex.h>
-#include <linux/types.h>
#include <asm/io.h>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] fix duplicate include in emu10k1.h
2009-02-26 8:57 ` [PATCH] fix duplicate include in emu10k1.h Arnd Bergmann
@ 2009-02-26 9:03 ` Takashi Iwai
0 siblings, 0 replies; 3+ messages in thread
From: Takashi Iwai @ 2009-02-26 9:03 UTC (permalink / raw)
To: Arnd Bergmann
Cc: hpa, mingo, dwmw2, acme, airlied, perex, yoshfuji, mchehab, tglx,
hpa, linux-kernel
At Thu, 26 Feb 2009 09:57:27 +0100,
Arnd Bergmann wrote:
>
> The earlier patch 'make most exported headers use strict integer types'
> accidentally includes <types.h> both from the common and from the
> kernel-only parts.
>
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
To both patches (better merged, though),
Acked-by: Takashi Iwai <tiwai@suse.de>
Thanks!
Takashi
>
> ---
> On Thursday 26 February 2009, you wrote:
>
> > > @@ -34,6 +36,8 @@
> > > #include <sound/timer.h>
> > > #include <linux/interrupt.h>
> > > #include <linux/mutex.h>
> > > +#include <linux/types.h>
> > > +
> >
> > Isn't the second inclusion superfluous?
> >
> Yes, I must have introduced the second one first, but in the
> wrong section (kernel only), and then didn't notice it when
> introducing it again to fix headers_check.
>
> --- a/include/sound/emu10k1.h
> +++ b/include/sound/emu10k1.h
> @@ -36,7 +36,6 @@
> #include <sound/timer.h>
> #include <linux/interrupt.h>
> #include <linux/mutex.h>
> -#include <linux/types.h>
>
> #include <asm/io.h>
>
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-02-26 9:04 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <tip-57b4b9d7b56d283b6619a893341be16d1a0467a6@kernel.org>
2009-02-26 8:47 ` [tip:core/header-fixes] make most exported headers use strict integer types Takashi Iwai
2009-02-26 8:57 ` [PATCH] fix duplicate include in emu10k1.h Arnd Bergmann
2009-02-26 9:03 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®