* [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
@ 2009-03-14 19:58 Jing Huang
2009-03-14 21:02 ` Sam Ravnborg
0 siblings, 1 reply; 7+ messages in thread
From: Jing Huang @ 2009-03-14 19:58 UTC (permalink / raw)
To: James.Bottomley; +Cc: kgudipat, linux-kernel, linux-scsi, rvadivel, vravindr
From: Jing Huang <huangj@brocade.com>
This patch contains Makefile and Kconfig file for scsi and bfa. It is created
using 2.6.29-rc8 kernel.
Signed-off-by: Jing Huang <huangj@brocade.com>
---
Kconfig | 9 +++++++++
Makefile | 1 +
bfa/Makefile | 28 ++++++++++++++++++++++++++++
3 files changed, 38 insertions(+)
diff -urpN orig/drivers/scsi/bfa/Makefile patch/drivers/scsi/bfa/Makefile
--- orig/drivers/scsi/bfa/Makefile 1969-12-31 16:00:00.000000000 -0800
+++ patch/drivers/scsi/bfa/Makefile 2009-03-14 11:44:59.337712000 -0700
@@ -0,0 +1,28 @@
+#
+# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
+# All rights reserved
+# www.brocade.com
+#
+# Linux driver for Brocade Fibre Channel Host Bus Adapter.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License (GPL) Version 2 as
+# published by the Free Software Foundation
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+obj-$(CONFIG_SCSI_BFA_FC) := bfa.o
+
+bfa-objs := bfad.o bfad_intr.o bfad_os.o bfad_im.o bfad_attr.o bfad_fwimg.o \
+ bfa_core.o bfa_ioc.o bfa_iocfc.o bfa_fcxp.o bfa_diag.o \
+ bfa_fcdiag.o bfa_lps.o bfa_hw_cb.o bfa_hw_ct.o bfa_drv.o \
+ bfa_intr.o bfa_timer.o bfa_rport.o bfa_port.o bfa_uf.o \
+ bfa_sgpg.o bfa_module.o bfa_ioim.o bfa_itnim.o bfa_fcpim.o \
+ bfa_tskim.o bfa_port.o bfa_vport.o bfa_lport.o bfa_fabric.o \
+ bfa_auth.o bfa_vfapi.o bfa_log.o bfa_log_module.o bfa_csdebug.o \
+ bfa_sm.o plog.o
+
+EXTRA_CFLAGS += -I$(obj) -I$(obj)/include
diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
--- orig/drivers/scsi/Kconfig 2009-03-14 11:44:59.381081000 -0700
+++ patch/drivers/scsi/Kconfig 2009-03-14 11:44:53.382314000 -0700
@@ -1797,6 +1797,15 @@ config SCSI_SRP
To compile this driver as a module, choose M here: the
module will be called libsrp.
+config SCSI_BFA_FC
+ tristate "Brocade BFA Fibre Channel Support"
+ depends on PCI && SCSI
+ help
+ This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
+
+ To compile this driver as a module, choose M here. The module will
+ be called bfa.
+
endif # SCSI_LOWLEVEL
source "drivers/scsi/pcmcia/Kconfig"
diff -urpN orig/drivers/scsi/Makefile patch/drivers/scsi/Makefile
--- orig/drivers/scsi/Makefile 2009-03-14 11:44:59.393920000 -0700
+++ patch/drivers/scsi/Makefile 2009-03-14 11:44:53.417722000 -0700
@@ -84,6 +84,7 @@ obj-$(CONFIG_SCSI_QLOGIC_1280) += qla128
obj-$(CONFIG_SCSI_QLA_FC) += qla2xxx/
obj-$(CONFIG_SCSI_QLA_ISCSI) += qla4xxx/
obj-$(CONFIG_SCSI_LPFC) += lpfc/
+obj-$(CONFIG_SCSI_BFA_FC) += bfa/
obj-$(CONFIG_SCSI_PAS16) += pas16.o
obj-$(CONFIG_SCSI_T128) += t128.o
obj-$(CONFIG_SCSI_DMX3191D) += dmx3191d.o
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
2009-03-14 19:58 [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile) Jing Huang
@ 2009-03-14 21:02 ` Sam Ravnborg
0 siblings, 0 replies; 7+ messages in thread
From: Sam Ravnborg @ 2009-03-14 21:02 UTC (permalink / raw)
To: Jing Huang
Cc: James.Bottomley, kgudipat, linux-kernel, linux-scsi, rvadivel, vravindr
On Sat, Mar 14, 2009 at 12:58:41PM -0700, Jing Huang wrote:
> From: Jing Huang <huangj@brocade.com>
>
> This patch contains Makefile and Kconfig file for scsi and bfa. It is created
> using 2.6.29-rc8 kernel.
>
> Signed-off-by: Jing Huang <huangj@brocade.com>
> ---
> Kconfig | 9 +++++++++
> Makefile | 1 +
> bfa/Makefile | 28 ++++++++++++++++++++++++++++
> 3 files changed, 38 insertions(+)
>
> diff -urpN orig/drivers/scsi/bfa/Makefile patch/drivers/scsi/bfa/Makefile
> --- orig/drivers/scsi/bfa/Makefile 1969-12-31 16:00:00.000000000 -0800
> +++ patch/drivers/scsi/bfa/Makefile 2009-03-14 11:44:59.337712000 -0700
> @@ -0,0 +1,28 @@
> +#
> +# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
> +# All rights reserved
> +# www.brocade.com
> +#
> +# Linux driver for Brocade Fibre Channel Host Bus Adapter.
> +#
> +# This program is free software; you can redistribute it and/or modify it
> +# under the terms of the GNU General Public License (GPL) Version 2 as
> +# published by the Free Software Foundation
> +#
> +# This program is distributed in the hope that it will be useful, but
> +# WITHOUT ANY WARRANTY; without even the implied warranty of
> +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
> +# General Public License for more details.
> +#
No one else needs this boiler plate - please remove it.
> +obj-$(CONFIG_SCSI_BFA_FC) := bfa.o
OK
> +
> +bfa-objs := bfad.o bfad_intr.o bfad_os.o bfad_im.o bfad_attr.o bfad_fwimg.o \
> + bfa_core.o bfa_ioc.o bfa_iocfc.o bfa_fcxp.o bfa_diag.o \
> + bfa_fcdiag.o bfa_lps.o bfa_hw_cb.o bfa_hw_ct.o bfa_drv.o \
> + bfa_intr.o bfa_timer.o bfa_rport.o bfa_port.o bfa_uf.o \
> + bfa_sgpg.o bfa_module.o bfa_ioim.o bfa_itnim.o bfa_fcpim.o \
> + bfa_tskim.o bfa_port.o bfa_vport.o bfa_lport.o bfa_fabric.o \
> + bfa_auth.o bfa_vfapi.o bfa_log.o bfa_log_module.o bfa_csdebug.o \
> + bfa_sm.o plog.o
a) use of -objs is deprecated.
Please use:
bfa-y := bfad.o ...
b) As a style thing the following is preferred (by me at least):
bfa-y := bfad.o bfad_intr.o bfad_os.o bfad_im.o bfad_attr.o bfad_fwimg.o
# core stuff
bfa-y += bfa_core.o bfa_ioc.o bfa_iocfc.o bfa_fcxp.o bfa_diag.o
# interrup hander
bfa-y += bfa_intr.o
No longer any need for escaping the newline with a backslahs
And you can add descriptive comments too.
> +EXTRA_CFLAGS += -I$(obj) -I$(obj)/include
Neither of the above is needed.
If you really need to specify addtional options to gcc use:
ccflags-y := ...
Sam
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
@ 2009-03-24 0:12 Krishna Gudipati
0 siblings, 0 replies; 7+ messages in thread
From: Krishna Gudipati @ 2009-03-24 0:12 UTC (permalink / raw)
To: James.Bottomley
Cc: huangj, kgudipat, linux-kernel, linux-scsi, rvadivel, vravindr
From: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
the code review comments from previous submission.
Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
---
Kconfig | 9 +++++++++
Makefile | 1 +
bfa/Makefile | 12 ++++++++++++
3 files changed, 22 insertions(+)
diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
--- orig/drivers/scsi/Kconfig 2009-03-23 15:33:14.943524000 -0700
+++ patch/drivers/scsi/Kconfig 2009-03-23 15:33:09.313636000 -0700
@@ -1797,6 +1797,15 @@ config SCSI_SRP
To compile this driver as a module, choose M here: the
module will be called libsrp.
+config SCSI_BFA_FC
+ tristate "Brocade BFA Fibre Channel Support"
+ depends on PCI && SCSI
+ help
+ This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
+
+ To compile this driver as a module, choose M here. The module will
+ be called bfa.
+
endif # SCSI_LOWLEVEL
source "drivers/scsi/pcmcia/Kconfig"
diff -urpN orig/drivers/scsi/Makefile patch/drivers/scsi/Makefile
--- orig/drivers/scsi/Makefile 2009-03-23 15:33:14.957029000 -0700
+++ patch/drivers/scsi/Makefile 2009-03-23 15:33:09.354116000 -0700
@@ -84,6 +84,7 @@ obj-$(CONFIG_SCSI_QLOGIC_1280) += qla128
obj-$(CONFIG_SCSI_QLA_FC) += qla2xxx/
obj-$(CONFIG_SCSI_QLA_ISCSI) += qla4xxx/
obj-$(CONFIG_SCSI_LPFC) += lpfc/
+obj-$(CONFIG_SCSI_BFA_FC) += bfa/
obj-$(CONFIG_SCSI_PAS16) += pas16.o
obj-$(CONFIG_SCSI_T128) += t128.o
obj-$(CONFIG_SCSI_DMX3191D) += dmx3191d.o
diff -urpN orig/drivers/scsi/bfa/Makefile patch/drivers/scsi/bfa/Makefile
--- orig/drivers/scsi/bfa/Makefile 1969-12-31 16:00:00.000000000 -0800
+++ patch/drivers/scsi/bfa/Makefile 2009-03-23 15:33:14.917161000 -0700
@@ -0,0 +1,12 @@
+#
+# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
+# All rights reserved
+# www.brocade.com
+#
+# Linux driver for Brocade Fibre Channel Host Bus Adapter Makefile.
+#
+obj-$(CONFIG_SCSI_BFA_FC) := bfa.o
+
+bfa-y := bfad.o bfad_intr.o bfad_os.o bfad_im.o bfad_attr.o bfad_fwimg.o bfa_core.o bfa_ioc.o bfa_iocfc.o bfa_fcxp.o bfa_lps.o bfa_hw_cb.o bfa_hw_ct.o bfa_intr.o bfa_timer.o bfa_rport.o bfa_port.o bfa_uf.o bfa_sgpg.o bfa_module.o bfa_ioim.o bfa_itnim.o bfa_fcpim.o bfa_tskim.o bfa_port.o bfa_vport.o bfa_lport.o bfa_fabric.o bfa_auth.o bfa_vfapi.o bfa_log.o bfa_log_module.o bfa_csdebug.o bfa_sm.o plog.o
+
+EXTRA_CFLAGS += -I$(obj) -I$(obj)/include
^ permalink raw reply [flat|nested] 7+ messages in thread
* [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
@ 2009-04-02 3:35 Krishna Gudipati
2009-04-02 13:36 ` James Bottomley
0 siblings, 1 reply; 7+ messages in thread
From: Krishna Gudipati @ 2009-04-02 3:35 UTC (permalink / raw)
To: James.Bottomley
Cc: huangj, kgudipat, linux-kernel, linux-scsi, nkattang, rvadivel, vravindr
From: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
the code review comments from previous submission.
Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
---
Kconfig | 9 +++++++++
Makefile | 1 +
bfa/Makefile | 27 +++++++++++++++++++++++++++
3 files changed, 37 insertions(+)
diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
--- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
+++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
@@ -1797,6 +1797,15 @@ config SCSI_SRP
To compile this driver as a module, choose M here: the
module will be called libsrp.
+config SCSI_BFA_FC
+ tristate "Brocade BFA Fibre Channel Support"
+ depends on PCI && SCSI
+ help
+ This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
+
+ To compile this driver as a module, choose M here. The module will
+ be called bfa.
+
endif # SCSI_LOWLEVEL
source "drivers/scsi/pcmcia/Kconfig"
diff -urpN orig/drivers/scsi/Makefile patch/drivers/scsi/Makefile
--- orig/drivers/scsi/Makefile 2009-04-01 20:08:49.298683000 -0700
+++ patch/drivers/scsi/Makefile 2009-04-01 20:08:44.040005000 -0700
@@ -84,6 +84,7 @@ obj-$(CONFIG_SCSI_QLOGIC_1280) += qla128
obj-$(CONFIG_SCSI_QLA_FC) += qla2xxx/
obj-$(CONFIG_SCSI_QLA_ISCSI) += qla4xxx/
obj-$(CONFIG_SCSI_LPFC) += lpfc/
+obj-$(CONFIG_SCSI_BFA_FC) += bfa/
obj-$(CONFIG_SCSI_PAS16) += pas16.o
obj-$(CONFIG_SCSI_T128) += t128.o
obj-$(CONFIG_SCSI_DMX3191D) += dmx3191d.o
diff -urpN orig/drivers/scsi/bfa/Makefile patch/drivers/scsi/bfa/Makefile
--- orig/drivers/scsi/bfa/Makefile 1969-12-31 16:00:00.000000000 -0800
+++ patch/drivers/scsi/bfa/Makefile 2009-04-01 20:08:49.244443000 -0700
@@ -0,0 +1,27 @@
+#
+# Copyright (c) 2005-2008 Brocade Communications Systems, Inc.
+# All rights reserved
+# www.brocade.com
+#
+# Linux driver for Brocade Fibre Channel Host Bus Adapter.
+#
+# This program is free software; you can redistribute it and/or modify it
+# under the terms of the GNU General Public License (GPL) Version 2 as
+# published by the Free Software Foundation
+#
+# This program is distributed in the hope that it will be useful, but
+# WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
+# General Public License for more details.
+#
+obj-$(CONFIG_SCSI_BFA_FC) := bfa.o
+
+bfa-objs := bfad.o bfad_intr.o bfad_os.o bfad_im.o bfad_attr.o bfad_fwimg.o \
+ bfa_core.o bfa_ioc.o bfa_iocfc.o bfa_fcxp.o \
+ bfa_lps.o bfa_hw_cb.o bfa_hw_ct.o bfa_intr.o bfa_timer.o \
+ bfa_rport.o bfa_port.o bfa_uf.o bfa_sgpg.o bfa_module.o bfa_ioim.o \
+ bfa_itnim.o bfa_fcpim.o bfa_tskim.o bfa_port.o bfa_vport.o \
+ bfa_lport.o bfa_fabric.o bfa_auth.o bfa_vfapi.o \
+ bfa_log.o bfa_log_module.o bfa_csdebug.o bfa_sm.o plog.o
+
+EXTRA_CFLAGS += -I$(obj) -I$(obj)/include
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
2009-04-02 3:35 Krishna Gudipati
@ 2009-04-02 13:36 ` James Bottomley
2009-04-04 12:41 ` Jing Huang
0 siblings, 1 reply; 7+ messages in thread
From: James Bottomley @ 2009-04-02 13:36 UTC (permalink / raw)
To: Krishna Gudipati
Cc: huangj, linux-kernel, linux-scsi, nkattang, rvadivel, vravindr
On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
> From: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
>
> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
> the code review comments from previous submission.
>
> Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
> ---
> Kconfig | 9 +++++++++
> Makefile | 1 +
> bfa/Makefile | 27 +++++++++++++++++++++++++++
> 3 files changed, 37 insertions(+)
>
> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
> +++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
> @@ -1797,6 +1797,15 @@ config SCSI_SRP
> To compile this driver as a module, choose M here: the
> module will be called libsrp.
>
> +config SCSI_BFA_FC
> + tristate "Brocade BFA Fibre Channel Support"
> + depends on PCI && SCSI
> + help
> + This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
> +
> + To compile this driver as a module, choose M here. The module will
> + be called bfa.
> +
You're still not using the FC transport class to export common sysfs FC
information or to help make your driver smaller. I thought you were
going to fix this after this was noted in your first submission to
linux-scsi on 24 September?
James
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
2009-04-02 13:36 ` James Bottomley
@ 2009-04-04 12:41 ` Jing Huang
2009-04-04 13:19 ` James Bottomley
0 siblings, 1 reply; 7+ messages in thread
From: Jing Huang @ 2009-04-04 12:41 UTC (permalink / raw)
To: James Bottomley
Cc: Krishna Gudipati, huangj, linux-kernel, linux-scsi, nkattang,
rvadivel, vravindr
On Thu, Apr 2, 2009 at 9:36 PM, James Bottomley
<James.Bottomley@hansenpartnership.com> wrote:
> On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
>> From: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
>>
>> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
>> the code review comments from previous submission.
>>
>> Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
>> ---
>> Kconfig | 9 +++++++++
>> Makefile | 1 +
>> bfa/Makefile | 27 +++++++++++++++++++++++++++
>> 3 files changed, 37 insertions(+)
>>
>> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
>> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
>> +++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
>> @@ -1797,6 +1797,15 @@ config SCSI_SRP
>> To compile this driver as a module, choose M here: the
>> module will be called libsrp.
>>
>> +config SCSI_BFA_FC
>> + tristate "Brocade BFA Fibre Channel Support"
>> + depends on PCI && SCSI
>> + help
>> + This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
>> +
>> + To compile this driver as a module, choose M here. The module will
>> + be called bfa.
>> +
>
> You're still not using the FC transport class to export common sysfs FC
> information or to help make your driver smaller. I thought you were
> going to fix this after this was noted in your first submission to
> linux-scsi on 24 September?
>
> James
>
>
Hi James,
We removed Brocade specific sysfs code after first linux-scsi
submission. Can you please
clarify where we are still not using the FC transport class to export
common sysfs FC
information? We do use the fc transport template to create the common
sysfs FC attributes
(in bfad_attr.c) under /sys/class/fc_host/<host#>
Thanks
Jing
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile)
2009-04-04 12:41 ` Jing Huang
@ 2009-04-04 13:19 ` James Bottomley
0 siblings, 0 replies; 7+ messages in thread
From: James Bottomley @ 2009-04-04 13:19 UTC (permalink / raw)
To: Jing Huang
Cc: Krishna Gudipati, huangj, linux-kernel, linux-scsi, nkattang,
rvadivel, vravindr
On Sat, 2009-04-04 at 20:41 +0800, Jing Huang wrote:
> On Thu, Apr 2, 2009 at 9:36 PM, James Bottomley
> <James.Bottomley@hansenpartnership.com> wrote:
> > On Wed, 2009-04-01 at 20:35 -0700, Krishna Gudipati wrote:
> >> From: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
> >>
> >> This patch contains Makefile and Kconfig file for scsi and bfa.Fixed
> >> the code review comments from previous submission.
> >>
> >> Signed-off-by: Krishna Chaitanya Gudipati <kgudipat@brocade.com>
> >> ---
> >> Kconfig | 9 +++++++++
> >> Makefile | 1 +
> >> bfa/Makefile | 27 +++++++++++++++++++++++++++
> >> 3 files changed, 37 insertions(+)
> >>
> >> diff -urpN orig/drivers/scsi/Kconfig patch/drivers/scsi/Kconfig
> >> --- orig/drivers/scsi/Kconfig 2009-04-01 20:08:49.271161000 -0700
> >> +++ patch/drivers/scsi/Kconfig 2009-04-01 20:08:44.003822000 -0700
> >> @@ -1797,6 +1797,15 @@ config SCSI_SRP
> >> To compile this driver as a module, choose M here: the
> >> module will be called libsrp.
> >>
> >> +config SCSI_BFA_FC
> >> + tristate "Brocade BFA Fibre Channel Support"
> >> + depends on PCI && SCSI
> >> + help
> >> + This bfa driver supports all Brocade PCIe Fibre Channel host adapters.
> >> +
> >> + To compile this driver as a module, choose M here. The module will
> >> + be called bfa.
> >> +
> >
> > You're still not using the FC transport class to export common sysfs FC
> > information or to help make your driver smaller. I thought you were
> > going to fix this after this was noted in your first submission to
> > linux-scsi on 24 September?
> >
> > James
> >
> >
>
> Hi James,
>
> We removed Brocade specific sysfs code after first linux-scsi
> submission. Can you please
> clarify where we are still not using the FC transport class to export
> common sysfs FC
> information? We do use the fc transport template to create the common
> sysfs FC attributes
> (in bfad_attr.c) under /sys/class/fc_host/<host#>
Ah ... I was going by the fact that you don't select SCSI_FC_ATTRS in
the Kconfig ... so this is just something as simple as a missing select?
(Without the select you'll fail some of the random compile tests because
the needed scsi_transport_fc code won't be present).
James
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2009-04-04 13:20 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-03-14 19:58 [PATCH 4/5] bfa: Brocade BFA FC SCSI driver (makefile) Jing Huang
2009-03-14 21:02 ` Sam Ravnborg
2009-03-24 0:12 Krishna Gudipati
2009-04-02 3:35 Krishna Gudipati
2009-04-02 13:36 ` James Bottomley
2009-04-04 12:41 ` Jing Huang
2009-04-04 13:19 ` James Bottomley
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®