mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: viro@ZenIV.linux.org.uk
Cc: dhowells@redhat.com, nfsv4@linux-nfs.org,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: [PATCH 27/43] NFS: Add comment banners to some NFS functions [ver #46]
Date: Thu, 02 Apr 2009 00:05:40 +0100	[thread overview]
Message-ID: <20090401230540.28177.9638.stgit@warthog.procyon.org.uk> (raw)
In-Reply-To: <20090401230321.28177.12010.stgit@warthog.procyon.org.uk>

Add comment banners to some NFS functions so that they can be modified by the
NFS fscache patches for further information.

Signed-off-by: David Howells <dhowells@redhat.com>
Acked-by: Steve Dickson <steved@redhat.com>
Acked-by: Trond Myklebust <Trond.Myklebust@netapp.com>
---

 fs/nfs/file.c |   26 ++++++++++++++++++++++++++
 1 files changed, 26 insertions(+), 0 deletions(-)


diff --git a/fs/nfs/file.c b/fs/nfs/file.c
index 0abf3f3..f5bc54d 100644
--- a/fs/nfs/file.c
+++ b/fs/nfs/file.c
@@ -409,6 +409,13 @@ static int nfs_write_end(struct file *file, struct address_space *mapping,
 	return copied;
 }
 
+/*
+ * Partially or wholly invalidate a page
+ * - Release the private state associated with a page if undergoing complete
+ *   page invalidation
+ * - Called if either PG_private or PG_private_2 is set on the page
+ * - Caller holds page lock
+ */
 static void nfs_invalidate_page(struct page *page, unsigned long offset)
 {
 	dfprintk(PAGECACHE, "NFS: invalidate_page(%p, %lu)\n", page, offset);
@@ -419,6 +426,12 @@ static void nfs_invalidate_page(struct page *page, unsigned long offset)
 	nfs_wb_page_cancel(page->mapping->host, page);
 }
 
+/*
+ * Attempt to release the private state associated with a page
+ * - Called if either PG_private or PG_private_2 is set on the page
+ * - Caller holds page lock
+ * - Return true (may release page) or false (may not)
+ */
 static int nfs_release_page(struct page *page, gfp_t gfp)
 {
 	dfprintk(PAGECACHE, "NFS: release_page(%p)\n", page);
@@ -427,6 +440,14 @@ static int nfs_release_page(struct page *page, gfp_t gfp)
 	return 0;
 }
 
+/*
+ * Attempt to clear the private state associated with a page when an error
+ * occurs that requires the cached contents of an inode to be written back or
+ * destroyed
+ * - Called if either PG_private or PG_private_2 is set on the page
+ * - Caller holds page lock
+ * - Return 0 if successful, -error otherwise
+ */
 static int nfs_launder_page(struct page *page)
 {
 	struct inode *inode = page->mapping->host;
@@ -451,6 +472,11 @@ const struct address_space_operations nfs_file_aops = {
 	.launder_page = nfs_launder_page,
 };
 
+/*
+ * Notification that a PTE pointing to an NFS page is about to be made
+ * writable, implying that someone is about to modify the page through a
+ * shared-writable mapping
+ */
 static int nfs_vm_page_mkwrite(struct vm_area_struct *vma, struct vm_fault *vmf)
 {
 	struct page *page = vmf->page;


  parent reply	other threads:[~2009-04-01 23:20 UTC|newest]

Thread overview: 83+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <200904030051.10644.nickpiggin@yahoo.com.au>
2009-04-01 23:03 ` [PATCH 00/43] Permit filesystem local caching " David Howells
2009-04-01 23:03   ` [PATCH 01/43] Create a dynamically sized pool of threads for doing very slow work items " David Howells
2009-04-01 23:03   ` [PATCH 02/43] Make slow-work thread pool actually dynamic " David Howells
2009-04-01 23:03   ` [PATCH 03/43] Make the slow work pool configurable " David Howells
2009-04-01 23:03   ` [PATCH 04/43] Document the slow work thread pool " David Howells
2009-04-01 23:03   ` [PATCH 05/43] FS-Cache: Release page->private after failed readahead " David Howells
2009-04-02 14:21     ` David Howells
2009-04-02 17:17     ` Rik van Riel
2009-04-01 23:03   ` [PATCH 06/43] FS-Cache: Recruit a couple of page flags for cache management " David Howells
2009-04-02 14:36     ` David Howells
2009-04-02 15:25       ` Nick Piggin
2009-04-02 15:51       ` David Howells
2009-04-02 16:15         ` Nick Piggin
2009-04-02 16:53           ` Nick Piggin
2009-04-02 17:09           ` David Howells
2009-04-02 17:31             ` Nick Piggin
2009-04-02 17:40             ` David Howells
2009-04-02 18:14               ` Nick Piggin
2009-04-02 19:19               ` Trond Myklebust
2009-04-03  1:11               ` David Howells
2009-04-02 16:48         ` What I mean by a 'netfs' when dealing with FS-Cache David Howells
2009-04-02 17:06         ` David Howells
2009-04-02 18:23     ` [PATCH 06/43] FS-Cache: Recruit a couple of page flags for cache management [ver #46] Rik van Riel
2009-04-01 23:03   ` [PATCH 07/43] FS-Cache: Add the FS-Cache netfs API and documentation " David Howells
2009-04-01 23:04   ` [PATCH 08/43] FS-Cache: Add the FS-Cache cache backend " David Howells
2009-04-01 23:04   ` [PATCH 09/43] FS-Cache: Add main configuration option, module entry points and debugging " David Howells
2009-04-01 23:04   ` [PATCH 10/43] FS-Cache: Add use of /proc and presentation of statistics " David Howells
2009-04-01 23:04   ` [PATCH 11/43] FS-Cache: Root index definition " David Howells
2009-04-01 23:04   ` [PATCH 12/43] FS-Cache: Add cache tag handling " David Howells
2009-04-01 23:04   ` [PATCH 13/43] FS-Cache: Add cache management " David Howells
2009-04-01 23:04   ` [PATCH 14/43] FS-Cache: Provide a slab for cookie allocation " David Howells
2009-04-01 23:04   ` [PATCH 15/43] FS-Cache: Add netfs registration " David Howells
2009-04-01 23:04   ` [PATCH 16/43] FS-Cache: Bit waiting helpers " David Howells
2009-04-01 23:04   ` [PATCH 17/43] FS-Cache: Object management state machine " David Howells
2009-04-01 23:04   ` [PATCH 18/43] FS-Cache: Implement the cookie management part of the netfs API " David Howells
2009-04-01 23:04   ` [PATCH 19/43] FS-Cache: Add and document asynchronous operation handling " David Howells
2009-04-01 23:05   ` [PATCH 20/43] FS-Cache: Implement data I/O part of netfs API " David Howells
2009-04-01 23:05   ` [PATCH 21/43] CacheFiles: Be consistent about the use of mapping vs file->f_mapping in Ext3 " David Howells
2009-04-02 18:52     ` Rik van Riel
2009-04-01 23:05   ` [PATCH 22/43] CacheFiles: Add a hook to write a single page of data to an inode " David Howells
2009-04-02 14:55     ` David Howells
2009-04-02 15:32       ` Nick Piggin
2009-04-02 16:37         ` Christoph Hellwig
2009-04-02 16:47           ` Nick Piggin
2009-04-02 16:55             ` Christoph Hellwig
2009-04-02 17:07               ` Nick Piggin
2009-04-02 17:26                 ` Jan Kara
2009-04-02 17:22             ` David Howells
2009-04-02 18:18             ` David Howells
2009-04-02 22:44             ` David Howells
2009-04-03 13:41             ` David Howells
2009-04-02 16:02       ` David Howells
2009-04-02 15:32     ` Peter Staubach
2009-04-02 16:03     ` David Howells
2009-04-02 18:48     ` Rik van Riel
2009-04-01 23:05   ` [PATCH 23/43] CacheFiles: Permit the page lock state to be monitored " David Howells
2009-04-02 15:37     ` Nick Piggin
2009-04-02 16:14     ` David Howells
2009-04-02 16:35       ` Nick Piggin
2009-04-02 17:05       ` David Howells
2009-04-02 18:03         ` Nick Piggin
2009-04-02 18:51     ` Rik van Riel
2009-04-01 23:05   ` [PATCH 24/43] CacheFiles: Export things for CacheFiles " David Howells
2009-04-02 18:53     ` Rik van Riel
2009-04-01 23:05   ` [PATCH 25/43] CacheFiles: A cache that backs onto a mounted filesystem " David Howells
2009-04-01 23:05   ` [PATCH 26/43] FS-Cache: Make kAFS use FS-Cache " David Howells
2009-04-01 23:05   ` David Howells [this message]
2009-04-01 23:05   ` [PATCH 28/43] NFS: Add FS-Cache option bit and debug bit " David Howells
2009-04-01 23:05   ` [PATCH 29/43] NFS: Permit local filesystem caching to be enabled for NFS " David Howells
2009-04-01 23:05   ` [PATCH 30/43] NFS: Register NFS for caching and retrieve the top-level index " David Howells
2009-04-01 23:06   ` [PATCH 31/43] NFS: Define and create server-level objects " David Howells
2009-04-01 23:06   ` [PATCH 32/43] NFS: Define and create superblock-level " David Howells
2009-04-01 23:06   ` [PATCH 33/43] NFS: Define and create inode-level cache " David Howells
2009-04-01 23:06   ` [PATCH 34/43] NFS: Use local disk inode cache " David Howells
2009-04-01 23:06   ` [PATCH 35/43] NFS: Invalidate FsCache page flags when cache removed " David Howells
2009-04-01 23:06   ` [PATCH 36/43] NFS: Add some new I/O counters for FS-Cache doing things for NFS " David Howells
2009-04-01 23:06   ` [PATCH 37/43] NFS: FS-Cache page management " David Howells
2009-04-01 23:06   ` [PATCH 38/43] NFS: Add read context retention for FS-Cache to call back with " David Howells
2009-04-01 23:06   ` [PATCH 39/43] NFS: nfs_readpage_async() needs to be accessible as a fallback for local caching " David Howells
2009-04-01 23:06   ` [PATCH 40/43] NFS: Read pages from FS-Cache into an NFS inode " David Howells
2009-04-01 23:06   ` [PATCH 41/43] NFS: Store pages from an NFS inode into a local cache " David Howells
2009-04-01 23:06   ` [PATCH 42/43] NFS: Display local caching state " David Howells
2009-04-01 23:07   ` [PATCH 43/43] NFS: Add mount options to enable local caching on NFS " David Howells

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090401230540.28177.9638.stgit@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nfsv4@linux-nfs.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®