* [PATCH -tip] x86: mm/pat.c pat_disable should be static
@ 2009-04-11 7:54 Jaswinder Singh Rajput
2009-04-11 8:05 ` Sam Ravnborg
0 siblings, 1 reply; 2+ messages in thread
From: Jaswinder Singh Rajput @ 2009-04-11 7:54 UTC (permalink / raw)
To: Ingo Molnar, x86 maintainers, Pallipadi, Venkatesh,
Suresh Siddha, LKML, Andrew Morton
Impact: reduce kernel size a bit, avoid sparse warning
Fixes sparse warning:
arch/x86/mm/pat.c:34:16: warning: symbol 'pat_disable' was not declared. Should it be static?
Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
---
arch/x86/mm/pat.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
index cc5e0e2..bc53d8d 100644
--- a/arch/x86/mm/pat.c
+++ b/arch/x86/mm/pat.c
@@ -31,7 +31,7 @@
#ifdef CONFIG_X86_PAT
int __read_mostly pat_enabled = 1;
-void __cpuinit pat_disable(const char *reason)
+static void __cpuinit pat_disable(const char *reason)
{
pat_enabled = 0;
printk(KERN_INFO "%s\n", reason);
--
1.6.0.6
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH -tip] x86: mm/pat.c pat_disable should be static
2009-04-11 7:54 [PATCH -tip] x86: mm/pat.c pat_disable should be static Jaswinder Singh Rajput
@ 2009-04-11 8:05 ` Sam Ravnborg
0 siblings, 0 replies; 2+ messages in thread
From: Sam Ravnborg @ 2009-04-11 8:05 UTC (permalink / raw)
To: Jaswinder Singh Rajput
Cc: Ingo Molnar, x86 maintainers, Pallipadi, Venkatesh,
Suresh Siddha, LKML, Andrew Morton
On Sat, Apr 11, 2009 at 01:24:53PM +0530, Jaswinder Singh Rajput wrote:
> Impact: reduce kernel size a bit, avoid sparse warning
>
> Fixes sparse warning:
> arch/x86/mm/pat.c:34:16: warning: symbol 'pat_disable' was not declared. Should it be static?
>
> Signed-off-by: Jaswinder Singh Rajput <jaswinderrajput@gmail.com>
> ---
> arch/x86/mm/pat.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/arch/x86/mm/pat.c b/arch/x86/mm/pat.c
> index cc5e0e2..bc53d8d 100644
> --- a/arch/x86/mm/pat.c
> +++ b/arch/x86/mm/pat.c
> @@ -31,7 +31,7 @@
> #ifdef CONFIG_X86_PAT
> int __read_mostly pat_enabled = 1;
>
> -void __cpuinit pat_disable(const char *reason)
> +static void __cpuinit pat_disable(const char *reason)
> {
> pat_enabled = 0;
> printk(KERN_INFO "%s\n", reason);
This is fixed in a better way.
See Marcin's patch: http://lkml.org/lkml/2009/4/10/384
If you had looked carefully at the call-sites you would have noticed that not all
of them were annotated __cpunint/__init.
Sam
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-04-11 8:04 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-11 7:54 [PATCH -tip] x86: mm/pat.c pat_disable should be static Jaswinder Singh Rajput
2009-04-11 8:05 ` Sam Ravnborg
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®