From: Oliver Neukum <oliver@neukum.org>
To: "Peter Holik" <peter@holik.at>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb driver for intellon based PLC like devolo dlan duo
Date: Sat, 18 Apr 2009 09:38:47 +0200 [thread overview]
Message-ID: <200904180938.48276.oliver@neukum.org> (raw)
In-Reply-To: <8472e581ef388a89b5ee8a7ed8dd1fdc.squirrel@webmail.it-technology.at>
Am Samstag 18 April 2009 09:16:28 schrieb Peter Holik:
> > + len = (skb->data[skb->len - 2] | (skb->data[skb->len - 1] << 8));
> >
> > Please use a conversion function.
>
> do you mean
>
> len = le16_to_cpu(skb->data[skb->len - 2] | (skb->data[skb->len - 1] <<
> 8));
Without the "|". Just dereference the pointer.
> pack_len &= 0x07ff;
>
> len = (__le16 *) __skb_push(skb, INT51X1_HEADER_SIZE);
> *len = cpu_to_le16(pack_len);
That's correct.
Regards
Oliver
next prev parent reply other threads:[~2009-04-18 7:38 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-17 14:10 Peter Holik
2009-04-17 14:32 ` Florian Fainelli
2009-04-17 19:07 ` Guennadi Liakhovetski
2009-04-18 8:55 ` David Miller
2009-04-18 19:54 ` Guennadi Liakhovetski
2009-04-19 4:15 ` David Miller
2009-04-19 4:24 ` David Miller
2009-04-19 8:32 ` Guennadi Liakhovetski
2009-04-19 8:35 ` David Miller
2009-04-18 6:48 ` Peter Holik
2009-04-18 10:22 ` Florian Fainelli
2009-04-18 13:42 ` Jon Smirl
2009-04-17 14:41 ` Oliver Neukum
2009-04-18 7:16 ` Peter Holik
2009-04-18 7:38 ` Oliver Neukum [this message]
2009-04-18 8:41 ` Peter Holik
2009-04-18 8:49 ` Oliver Neukum
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=200904180938.48276.oliver@neukum.org \
--to=oliver@neukum.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter@holik.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®