Re: [PATCH] usb driver for intellon based PLC like devolo dlan duo

[Florian Fainelli <florian@openwrt.org>]

Le Saturday 18 April 2009 08:48:22 Peter Holik, vous avez écrit :
> > Hi Peter,
> >
> > Nice to see such a driver coming up!
>
> thanks
>
> > Le Friday 17 April 2009 16:10:24 Peter Holik, vous avez écrit :
> >> Signed-off-by: Peter Holik <peter@holik.at>
> >> ---
> >>  drivers/net/usb/Kconfig    |    7 +
> >>  drivers/net/usb/Makefile   |    2 +-
> >>  drivers/net/usb/intellon.c |  273
> >> ++++++++++++++++++++++++++++++++++++++++++++ 3 files changed, 281
> >> insertions(+), 1 deletions(-)
> >>  create mode 100644 drivers/net/usb/intellon.c
> >>
> >> diff --git a/drivers/net/usb/Kconfig b/drivers/net/usb/Kconfig
> >> index 8ee2103..068faa5 100644
> >> --- a/drivers/net/usb/Kconfig
> >> +++ b/drivers/net/usb/Kconfig
> >> @@ -345,4 +345,11 @@ config USB_HSO
> >>  	  To compile this driver as a module, choose M here: the
> >>  	  module will be called hso.
> >>
> >> +config USB_NET_INTELLON
> >> +	tristate "Intellon PLC based usb adapter"
> >> +	depends on USB_USBNET
> >> +	help
> >> +	  Choose this option if you're using a PLC (Powerline Communications)
> >> +	  solution with an Intellon chip, like the "devolo dLan duo".
> >> +
> >
> > Please be more specific, i.e: using a USB-based PLC (...) solution.
> >
> > There might be support for PLC PHYs connected to a MII-bus in a near
> > future, even though they will not reside in drivers/net/usb/.
>
> What do you mean with the last sentence?

I mean that one might come up with a design that uses Intellon PLC PHY chips 
only with a custom MAC chip, not integrated MAC+PHY chips only, therefore a 
more specific naming is required, that's purely cosmetic though.

>
> >>  endmenu
> >> diff --git a/drivers/net/usb/Makefile b/drivers/net/usb/Makefile
> >> index 88a87ee..0fccfe9 100644
> >> --- a/drivers/net/usb/Makefile
> >> +++ b/drivers/net/usb/Makefile
> >> @@ -19,4 +19,4 @@ obj-$(CONFIG_USB_NET_CDC_SUBSET)	+= cdc_subset.o
> >>  obj-$(CONFIG_USB_NET_ZAURUS)	+= zaurus.o
> >>  obj-$(CONFIG_USB_NET_MCS7830)	+= mcs7830.o
> >>  obj-$(CONFIG_USB_USBNET)	+= usbnet.o
> >> -
> >> +obj-$(CONFIG_USB_NET_INTELLON)	+= intellon.o
> >
> > I would not name this intellon for the same reasons as explained below,
> > but rather int51x1.c since this driver will for instance not work with
> > HomePlug AV designs which use different Intellon integrated chips like
> > the 6000 and 6300 series.
>
> work in progress...

Cool :)

> Disagree, because i've taken "nibble" and "get_ethernet_addr" from
> cdc_ether.c to have the same code (the version of Jan was different).

Ok.
-- 
Best regards, Florian Fainelli
Email : florian@openwrt.org
http://openwrt.org
-------------------------------