* Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
@ 2009-04-28 21:33 Edward Goggin
2009-04-29 5:32 ` Ingo Molnar
0 siblings, 1 reply; 3+ messages in thread
From: Edward Goggin @ 2009-04-28 21:33 UTC (permalink / raw)
To: 'linux-kernel@vger.kernel.org'
Patch 1 of 1
Simple typo when enabling CONFIG_KDB_KDUMP.
Signed-off-by: Ed Goggin <egoggin@vmware.com>
--- linux-2.6.29/arch/x86/kernel/reboot.c 2009-04-28 14:37:30.000000000 -0400
+++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c 2009-04-28 14:37:37.000000000 -0400
@@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs *re
#ifdef CONFIG_X86_32
if (!user_mode_vm(regs)) {
crash_fixup_ss_esp(&fixed_regs, regs);
- regs = &fixed_Regs;
+ regs = &fixed_regs;
}
#endif
crash_save_cpu(regs, raw_smp_processor_id());
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
2009-04-28 21:33 Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP Edward Goggin
@ 2009-04-29 5:32 ` Ingo Molnar
2009-04-29 13:15 ` Edward Goggin
0 siblings, 1 reply; 3+ messages in thread
From: Ingo Molnar @ 2009-04-29 5:32 UTC (permalink / raw)
To: Edward Goggin; +Cc: 'linux-kernel@vger.kernel.org'
* Edward Goggin <egoggin@vmware.com> wrote:
> Patch 1 of 1
>
> Simple typo when enabling CONFIG_KDB_KDUMP.
>
> Signed-off-by: Ed Goggin <egoggin@vmware.com>
>
>
> --- linux-2.6.29/arch/x86/kernel/reboot.c 2009-04-28 14:37:30.000000000 -0400
> +++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c 2009-04-28 14:37:37.000000000 -0400
> @@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs *re
> #ifdef CONFIG_X86_32
> if (!user_mode_vm(regs)) {
> crash_fixup_ss_esp(&fixed_regs, regs);
> - regs = &fixed_Regs;
> + regs = &fixed_regs;
> }
> #endif
> crash_save_cpu(regs, raw_smp_processor_id());
There's no such code in the current upstream kernel. Exactly which
kernel version (sha1) are you sending a patch against?
Ingo
^ permalink raw reply [flat|nested] 3+ messages in thread* RE: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
2009-04-29 5:32 ` Ingo Molnar
@ 2009-04-29 13:15 ` Edward Goggin
0 siblings, 0 replies; 3+ messages in thread
From: Edward Goggin @ 2009-04-29 13:15 UTC (permalink / raw)
To: 'Ingo Molnar'; +Cc: 'linux-kernel@vger.kernel.org'
Good point. Its after applying a KDB patch from SGI. I'll submit
the patch to Keith Owens at SGI intead.
> -----Original Message-----
> From: Ingo Molnar [mailto:mingo@elte.hu]
> Sent: Wednesday, April 29, 2009 1:33 AM
> To: Edward Goggin
> Cc: 'linux-kernel@vger.kernel.org'
> Subject: Re: Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP
>
>
> * Edward Goggin <egoggin@vmware.com> wrote:
>
> > Patch 1 of 1
> >
> > Simple typo when enabling CONFIG_KDB_KDUMP.
> >
> > Signed-off-by: Ed Goggin <egoggin@vmware.com>
> >
> >
> > --- linux-2.6.29/arch/x86/kernel/reboot.c 2009-04-28
> 14:37:30.000000000 -0400
> > +++ linux-2.6.29.fix/arch/x86/kernel/./reboot.c
> 2009-04-28 14:37:37.000000000 -0400
> > @@ -649,7 +649,7 @@ void halt_current_cpu(struct pt_regs
> *re #ifdef
> > CONFIG_X86_32
> > if (!user_mode_vm(regs)) {
> > crash_fixup_ss_esp(&fixed_regs, regs);
> > - regs = &fixed_Regs;
> > + regs = &fixed_regs;
> > }
> > #endif
> > crash_save_cpu(regs, raw_smp_processor_id());
>
> There's no such code in the current upstream kernel. Exactly
> which kernel version (sha1) are you sending a patch against?
>
> Ingo
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2009-04-29 13:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2009-04-28 21:33 Simple typo in reboot.c when enabling CONFIG_KDB_KDUMP Edward Goggin
2009-04-29 5:32 ` Ingo Molnar
2009-04-29 13:15 ` Edward Goggin
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®