From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: nicolas.ferre@atmel.com, linux@maxim.org.za,
linux-kernel@vger.kernel.org,
Albin Tonnerre <albin.tonnerre@free-electrons.com>
Subject: Re: [PATCH] Switch atmel_serial to dev_pm_ops
Date: Mon, 3 Aug 2009 17:09:47 +0200 [thread overview]
Message-ID: <20090803170947.2f199b93@hskinnemoen-d830> (raw)
In-Reply-To: <1249310347-22291-1-git-send-email-albin.tonnerre@free-electrons.com>
Albin Tonnerre wrote:
> +static struct dev_pm_ops atmel_serial_pm_ops = {
> + .suspend = atmel_serial_suspend,
> + .resume = atmel_serial_resume,
> +};
> #else
> -#define atmel_serial_suspend NULL
> -#define atmel_serial_resume NULL
> +static struct dev_pm_ops atmel_serial_pm_ops;
Why not
#define atmel_serial_pm_ops NULL
> #endif
>
> static int __devinit atmel_serial_probe(struct platform_device *pdev)
> @@ -1603,11 +1607,10 @@ static int __devexit atmel_serial_remove(struct platform_device *pdev)
> static struct platform_driver atmel_serial_driver = {
> .probe = atmel_serial_probe,
> .remove = __devexit_p(atmel_serial_remove),
> - .suspend = atmel_serial_suspend,
> - .resume = atmel_serial_resume,
> .driver = {
> .name = "atmel_usart",
> .owner = THIS_MODULE,
> + .pm = &atmel_serial_pm_ops,
Please use a TAB instead of space to make everything nice and
consistent.
Other than that,
Acked-by: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
next prev parent reply other threads:[~2009-08-03 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 14:39 Albin Tonnerre
2009-08-03 15:09 ` Haavard Skinnemoen [this message]
2009-08-03 15:50 ` Albin Tonnerre
2009-08-03 16:01 ` Haavard Skinnemoen
2009-08-03 16:20 ` Frans Pop
2009-08-03 15:51 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803170947.2f199b93@hskinnemoen-d830 \
--to=haavard.skinnemoen@atmel.com \
--cc=albin.tonnerre@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®