mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Frans Pop <elendil@planet.nl>
To: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: haavard.skinnemoen@atmel.com, nicolas.ferre@atmel.com,
	linux@maxim.org.za, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Switch atmel_serial to dev_pm_ops
Date: Mon, 3 Aug 2009 18:20:41 +0200	[thread overview]
Message-ID: <200908031820.42760.elendil@planet.nl> (raw)
In-Reply-To: <20090803155049.GD5002@laptop>

Albin Tonnerre wrote:
>> Why not
> 
>> #define atmel_serial_pm_ops   NULL
> 
> Because the .pm field is set to the address of atmel_serial_pm_ops, and
> iirc taking the address of NULL is not allowed.

The following construction is possible however (first used by Magnus Damm 
for some of the SuperH drivers):

#ifdef CONFIG_PM
[...]
#define DRIVER_PM_OPS (&driver_pm_ops)
#else
#define DRIVER_PM_OPS NULL
#endif

...
      .driver = {
...
             .pm = DRIVER_PM_OPS,
      }
...

Cheers,
FJP

  parent reply	other threads:[~2009-08-03 16:20 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-03 14:39 Albin Tonnerre
2009-08-03 15:09 ` Haavard Skinnemoen
2009-08-03 15:50   ` Albin Tonnerre
2009-08-03 16:01     ` Haavard Skinnemoen
2009-08-03 16:20     ` Frans Pop [this message]
2009-08-03 15:51   ` Frans Pop

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=200908031820.42760.elendil@planet.nl \
    --to=elendil@planet.nl \
    --cc=albin.tonnerre@free-electrons.com \
    --cc=haavard.skinnemoen@atmel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@maxim.org.za \
    --cc=nicolas.ferre@atmel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®