From: Haavard Skinnemoen <haavard.skinnemoen@atmel.com>
To: Albin Tonnerre <albin.tonnerre@free-electrons.com>
Cc: nicolas.ferre@atmel.com, linux@maxim.org.za,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] Switch atmel_serial to dev_pm_ops
Date: Mon, 3 Aug 2009 18:01:37 +0200 [thread overview]
Message-ID: <20090803180137.6961a832@hskinnemoen-d830> (raw)
In-Reply-To: <20090803155049.GD5002@laptop>
Albin Tonnerre wrote:
> On Mon, Aug 03, 2009 at 05:09:47PM +0200, Haavard Skinnemoen wrote :
> > Why not
>
> > #define atmel_serial_pm_ops NULL
>
> Because the .pm field is set to the address of atmel_serial_pm_ops, and iirc
> taking the address of NULL is not allowed.
Good point.
> > > .name = "atmel_usart",
> > > .owner = THIS_MODULE,
> > > + .pm = &atmel_serial_pm_ops,
>
> > Please use a TAB instead of space to make everything nice and
> > consistent.
>
> That's weird, because my editor does show a TAB there, and applying the patch
> with git am results in a TAB.
Hmm, it doesn't show a TAB when I apply it here...
Oh well, it's not a big deal either way.
Haavard
next prev parent reply other threads:[~2009-08-03 16:01 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-03 14:39 Albin Tonnerre
2009-08-03 15:09 ` Haavard Skinnemoen
2009-08-03 15:50 ` Albin Tonnerre
2009-08-03 16:01 ` Haavard Skinnemoen [this message]
2009-08-03 16:20 ` Frans Pop
2009-08-03 15:51 ` Frans Pop
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20090803180137.6961a832@hskinnemoen-d830 \
--to=haavard.skinnemoen@atmel.com \
--cc=albin.tonnerre@free-electrons.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@maxim.org.za \
--cc=nicolas.ferre@atmel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®