mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: David Xiao <dxiao@broadcom.com>
Cc: Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Ben Dooks <ben-linux@fluff.org>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Robin Holt <holt@sgi.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	v4l2_linux <linux-media@vger.kernel.org>,
	"linux-arm-kernel@lists.arm.linux.org.uk" 
	<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: How to efficiently handle DMA and cache on ARMv7 ? (was "Is get_user_pages() enough to prevent pages from being swapped out ?")
Date: Thu, 6 Aug 2009 23:25:43 +0100	[thread overview]
Message-ID: <20090806222543.GG31579@n2100.arm.linux.org.uk> (raw)
In-Reply-To: <1249584374.29182.20.camel@david-laptop>

On Thu, Aug 06, 2009 at 11:46:14AM -0700, David Xiao wrote:
> On Thu, 2009-08-06 at 06:06 -0700, Laurent Pinchart wrote:
> > Hi Ben,
> > 
> > On Thursday 06 August 2009 13:46:19 Ben Dooks wrote:
> > > On Thu, Aug 06, 2009 at 12:08:21PM +0200, Laurent Pinchart wrote:
> > [snip]
> > > >
> > > > The second problem is to ensure cache coherency. As the userspace
> > > > application will read data from the video buffers, those buffers will end
> > > > up being cached in the processor's data cache. The driver does need to
> > > > invalidate the cache before starting the DMA operation (userspace could
> > > > in theory write to the buffers, but the data will be overwritten by DMA
> > > > anyway, so there's no need to clean the cache).
> > >
> > > You'll need to clean the write buffers, otherwise the CPU may have data
> > > queued that it has yet to write back to memory.
> > 
> > Good points, thanks.
> 
>    I thought this should have been taken care of by the CPU specific
> dma_inv_range routine. However, In arch/arm/mm/cache-v7.c,
> v7_dma_inv_range does not drain the write buffer; and the
> v6_dma_inv_range does that in the end of all the cache maintenance
> operaitons.

There's no such thing as "drain write buffer" in ARMv7.  There are
barriers instead, in particular dsb, which replaces the original
"drain write buffer" instruction.

As far as userspace DMA coherency, the only way you could do it with
current kernel APIs is by using get_user_pages(), creating a scatterlist
from those, and then passing it to dma_map_sg().  While the device has
ownership of the SG, userspace must _not_ touch the buffer until after
DMA has completed.

However, that won't work with ARMv7's speculative prefetching.  I'm
afraid with such things, DMA direct into userspace mappings becomes a
_lot_ harder, and lets face it, lots of Linux drivers just aren't going
to bother supporting this - we can't currently get agreement to have an
API to map DMA coherent pages into userspace!

  parent reply	other threads:[~2009-08-06 22:26 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 10:08 Laurent Pinchart
2009-08-06 11:46 ` Ben Dooks
2009-08-06 13:06   ` Laurent Pinchart
2009-08-06 18:46     ` David Xiao
2009-08-06 19:16       ` Chetan.Loke
2009-08-06 20:15       ` Jamie Lokier
2009-08-06 22:25       ` Russell King - ARM Linux [this message]
2009-08-07  5:59         ` David Xiao
2009-08-07  7:58           ` Laurent Pinchart
2009-08-07  8:10             ` Russell King - ARM Linux
2009-08-07  9:54               ` Jamie Lokier
2009-08-07  9:59                 ` Russell King - ARM Linux
2009-08-07 12:07                 ` Laurent Desnogues
2009-08-07 13:15                   ` Robin Holt
2009-08-07 19:01                     ` Russell King - ARM Linux
2009-08-07 20:11                       ` Laurent Pinchart
2009-08-07 20:28                         ` Russell King - ARM Linux
2009-08-07 22:25                           ` David Xiao
2009-08-10 13:49                           ` Laurent Pinchart
2009-08-07  8:08           ` Russell King - ARM Linux
2009-08-07 10:23           ` Jamie Lokier
2009-08-07 19:03             ` Russell King - ARM Linux
2009-08-11  9:31           ` Catalin Marinas
2009-08-11 18:23             ` David Xiao
2009-08-07  7:48         ` Laurent Pinchart
2009-08-25 12:53         ` Steven Walter
2009-08-25 22:02           ` David Xiao
2009-08-25 23:17             ` Laurent Pinchart
2009-08-26 17:22               ` David Xiao
2009-09-01 13:31                 ` Russell King - ARM Linux
2009-09-01 18:08                   ` David Xiao
2009-09-01 13:28           ` Russell King - ARM Linux
2009-09-01 13:43             ` Laurent Pinchart
2009-09-01 14:18               ` Russell King - ARM Linux
2009-09-01 16:53                 ` Hugh Dickins
2009-09-02 15:10               ` Imre Deak
2009-09-03  7:31                 ` Imre Deak
2009-09-03  8:36                 ` Russell King - ARM Linux
2009-09-08 13:05                   ` Steven Walter
2009-08-07  7:29       ` Laurent Pinchart
2009-08-07  8:12         ` Matthieu CASTET
2009-08-07 10:13           ` How to efficiently handle DMA and cache on ARMv7 ? (was " Is " Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20090806222543.GG31579@n2100.arm.linux.org.uk \
    --to=linux@arm.linux.org.uk \
    --cc=ben-linux@fluff.org \
    --cc=dxiao@broadcom.com \
    --cc=holt@sgi.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®