mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Steven Walter <stevenrwalter@gmail.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Imre Deak <imre.deak@nokia.com>,
	ext Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	David Xiao <dxiao@broadcom.com>, Ben Dooks <ben-linux@fluff.org>,
	Hugh Dickins <hugh.dickins@tiscali.co.uk>,
	Robin Holt <holt@sgi.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	v4l2_linux <linux-media@vger.kernel.org>,
	"linux-arm-kernel@lists.arm.linux.org.uk" 
	<linux-arm-kernel@lists.arm.linux.org.uk>
Subject: Re: How to efficiently handle DMA and cache on ARMv7 ? (was "Is  get_user_pages() enough to prevent pages from being swapped out ?")
Date: Tue, 8 Sep 2009 09:05:14 -0400	[thread overview]
Message-ID: <e06498070909080605sf11681en7ac55ddc024332e4@mail.gmail.com> (raw)
In-Reply-To: <20090903083600.GA7235@n2100.arm.linux.org.uk>

On Thu, Sep 3, 2009 at 4:36 AM, Russell King - ARM
Linux<linux@arm.linux.org.uk> wrote:
> On Wed, Sep 02, 2009 at 06:10:44PM +0300, Imre Deak wrote:
>> To my understanding buffers returned by dma_alloc_*, kmalloc, vmalloc
>> are ok:
>
> For dma_map_*, the only pages/addresses which are valid to pass are
> those returned by get_free_pages() or kmalloc.  Everything else is
> not permitted.
>
> Use of vmalloc'd and dma_alloc_* pages with the dma_map_* APIs is invalid
> use of the DMA API.  See the notes in the DMA-mapping.txt document
> against "dma_map_single".

Actually, DMA-mapping.txt seems to explicitly say that it's allowed to
use pages allocated by vmalloc:

"It is possible to DMA to the _underlying_ memory mapped into a
vmalloc() area, but this requires walking page tables to get the
physical addresses, and then translating each of those pages back to a
kernel address using something like __va()."

>> For user mappings I think you'd have to do an additional flush for
>> the direct mapping, while the user mapping is flushed in dma_map_*.
>
> I will not accept a patch which adds flushing of anything other than
> the kernel direct mapping in the dma_map_* functions, so please find
> a different approach.

What's the concern here?  Just the performance overhead of the checks
and additional flushes?  It seems much more desirable for the
dma_map_* API to take care of potential cache aliases than to require
every driver to manage it for itself.  After all, part of the purpose
of the DMA API is to manage the cache maintenance around DMAs in an
architecture-independent way.
-- 
-Steven Walter <stevenrwalter@gmail.com>

  reply	other threads:[~2009-09-08 13:05 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-08-06 10:08 Laurent Pinchart
2009-08-06 11:46 ` Ben Dooks
2009-08-06 13:06   ` Laurent Pinchart
2009-08-06 18:46     ` David Xiao
2009-08-06 19:16       ` Chetan.Loke
2009-08-06 20:15       ` Jamie Lokier
2009-08-06 22:25       ` Russell King - ARM Linux
2009-08-07  5:59         ` David Xiao
2009-08-07  7:58           ` Laurent Pinchart
2009-08-07  8:10             ` Russell King - ARM Linux
2009-08-07  9:54               ` Jamie Lokier
2009-08-07  9:59                 ` Russell King - ARM Linux
2009-08-07 12:07                 ` Laurent Desnogues
2009-08-07 13:15                   ` Robin Holt
2009-08-07 19:01                     ` Russell King - ARM Linux
2009-08-07 20:11                       ` Laurent Pinchart
2009-08-07 20:28                         ` Russell King - ARM Linux
2009-08-07 22:25                           ` David Xiao
2009-08-10 13:49                           ` Laurent Pinchart
2009-08-07  8:08           ` Russell King - ARM Linux
2009-08-07 10:23           ` Jamie Lokier
2009-08-07 19:03             ` Russell King - ARM Linux
2009-08-11  9:31           ` Catalin Marinas
2009-08-11 18:23             ` David Xiao
2009-08-07  7:48         ` Laurent Pinchart
2009-08-25 12:53         ` Steven Walter
2009-08-25 22:02           ` David Xiao
2009-08-25 23:17             ` Laurent Pinchart
2009-08-26 17:22               ` David Xiao
2009-09-01 13:31                 ` Russell King - ARM Linux
2009-09-01 18:08                   ` David Xiao
2009-09-01 13:28           ` Russell King - ARM Linux
2009-09-01 13:43             ` Laurent Pinchart
2009-09-01 14:18               ` Russell King - ARM Linux
2009-09-01 16:53                 ` Hugh Dickins
2009-09-02 15:10               ` Imre Deak
2009-09-03  7:31                 ` Imre Deak
2009-09-03  8:36                 ` Russell King - ARM Linux
2009-09-08 13:05                   ` Steven Walter [this message]
2009-08-07  7:29       ` Laurent Pinchart
2009-08-07  8:12         ` Matthieu CASTET
2009-08-07 10:13           ` How to efficiently handle DMA and cache on ARMv7 ? (was " Is " Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e06498070909080605sf11681en7ac55ddc024332e4@mail.gmail.com \
    --to=stevenrwalter@gmail.com \
    --cc=ben-linux@fluff.org \
    --cc=dxiao@broadcom.com \
    --cc=holt@sgi.com \
    --cc=hugh.dickins@tiscali.co.uk \
    --cc=imre.deak@nokia.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®